Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@

{% if my_reviewed.display_more %}
<div class="all-submissions-table__more">
<a href="{{ my_reviewed.url }}?reviewers={{ request.user.pk }}">{% trans "Show all" %}</a>
<a href="{{ my_reviewed.url }}">{% trans "Show all" %}</a>
</div>
{% endif %}
</div>
Expand Down Expand Up @@ -77,6 +77,20 @@ <h2 class="text-xl mb-2">
{% render_table my_inactive_submissions %}
</div>
{% endif %}

{% if all_submissions.table.data %}
<div class="wrapper wrapper--bottom-space">

<h4 class="heading heading--normal">{% trans "All Submissions" %}</h4>
{% render_table all_submissions.table %}

{% if all_submissions.display_more %}
<div class="all-submissions-table__more">
<a href="{{ all_submissions.url }}">{% trans "Show all" %}</a>
</div>
{% endif %}
</div>
{% endif %}
</div>

{% endblock %}
Expand Down
14 changes: 13 additions & 1 deletion hypha/apply/dashboard/views.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
from django.conf import settings
from django.db.models import F
from django.http import HttpResponseForbidden, HttpResponseRedirect
from django.shortcuts import render
from django.urls import reverse, reverse_lazy
Expand Down Expand Up @@ -317,11 +318,22 @@ def get_context_data(self, **kwargs):
"awaiting_reviews": self.awaiting_reviews(submissions),
"my_reviewed": self.my_reviewed(submissions),
"my_flagged": self.my_flagged(submissions),
"all_submissions": self.all_submissions(submissions),
}
)

return context

def all_submissions(self, submissions):
limit = 5
submissions = submissions.order_by(F("last_update").desc(nulls_last=True))

return {
"table": ReviewerSubmissionsTable(submissions[:limit], prefix="my-review-"),
"display_more": submissions.count() > limit,
"url": reverse("funds:submissions:list"),
}

def awaiting_reviews(self, submissions):
submissions = submissions.in_review_for(self.request.user).order_by(
"-submit_time"
Expand Down Expand Up @@ -354,7 +366,7 @@ def my_reviewed(self, submissions):
),
"table": ReviewerSubmissionsTable(submissions[:limit], prefix="my-review-"),
"display_more": submissions.count() > limit,
"url": reverse("funds:submissions:list"),
"url": reverse("funds:submissions:my_reviewed"),
}


Expand Down
7 changes: 6 additions & 1 deletion hypha/apply/funds/templates/funds/submissions.html
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,12 @@

{% adminbar %}
{% slot header %}
{% trans "All Submissions" %}<span class="submissions-count"> ({{ table.rows|length }})</span>
{% if page_heading %}
{{ page_heading }}
{% else %}
{% trans "All Submissions" %}
{% endif %}
<span class="submissions-count"> ({{ table.rows|length }})</span>
{% endslot %}
{% slot sub_heading %}{% trans "Search and filter all submissions" %}{% endslot %}

Expand Down
4 changes: 4 additions & 0 deletions hypha/apply/funds/urls.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
AwaitingReviewSubmissionsListView,
ExportSubmissionsByRound,
GroupingApplicationsListView,
MyReviewedSubmissionListView,
ReminderDeleteView,
ReviewerLeaderboard,
ReviewerLeaderboardDetail,
Expand Down Expand Up @@ -167,6 +168,9 @@
AwaitingReviewSubmissionsListView.as_view(),
name="awaiting_review",
),
path(
"my_reviewed/", MyReviewedSubmissionListView.as_view(), name="my_reviewed"
),
path(
"assignments/",
include(
Expand Down
12 changes: 5 additions & 7 deletions hypha/apply/funds/views.py
Original file line number Diff line number Diff line change
Expand Up @@ -404,11 +404,6 @@ class BaseReviewerSubmissionsTable(BaseAdminSubmissionsTable):
filterset_class = SubmissionReviewerFilterAndSearch

def get_queryset(self):
"""
If use_settings variable is set for ReviewerSettings use settings
parameters to filter submissions or return only reviewed_by as it
was by default.
"""
reviewer_settings = ReviewerSettings.for_request(self.request)
if reviewer_settings.use_settings:
return (
Expand All @@ -419,6 +414,9 @@ def get_queryset(self):
)
return super().get_queryset().reviewed_by(self.request.user)

def get_context_data(self, **kwargs):
return super().get_context_data(page_heading="My Reviewed", **kwargs)


@method_decorator(login_required, name="dispatch")
class AwaitingReviewSubmissionsListView(SingleTableMixin, ListView):
Expand Down Expand Up @@ -581,13 +579,13 @@ class GroupingApplicationsListView(TemplateView):
template_name = "funds/grouped_application_list.html"


class SubmissionReviewerListView(BaseReviewerSubmissionsTable):
class MyReviewedSubmissionListView(BaseReviewerSubmissionsTable):
template_name = "funds/submissions.html"


class SubmissionListView(ViewDispatcher):
admin_view = SubmissionAdminListView
reviewer_view = SubmissionReviewerListView
reviewer_view = SubmissionAdminListView


@method_decorator(staff_required, name="dispatch")
Expand Down