UID2-4739: use DefaultCredentialsProvider for KMS client in JWTTokenProvider#406
Open
sophia-chen-ttd wants to merge 3 commits into
Open
UID2-4739: use DefaultCredentialsProvider for KMS client in JWTTokenProvider#406sophia-chen-ttd wants to merge 3 commits into
sophia-chen-ttd wants to merge 3 commits into
Conversation
…rovider Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
sophia-chen-ttd
commented
Jun 4, 2026
sophia-chen-ttd
left a comment
Contributor
Author
There was a problem hiding this comment.
The swap from WebIdentityTokenFileCredentialsProvider to DefaultCredentialsProvider is correct and aligns with AWS SDK v2 best practice. The change broadens credential chain support (IRSA, EKS Pod Identity, instance profiles, env vars, etc.) without affecting the static-credentials fast-path. No functional regressions are expected, but the expanded credential chain introduces some operational subtleties worth noting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
JWTTokenProviderexplicitly constructsWebIdentityTokenFileCredentialsProviderfor KMS access, which ties it to OIDC/IRSA. Switching toDefaultCredentialsProvidermakes it compatible with EKS Pod Identity, instance profiles, and any future credential mechanism — matching the standard AWS SDK v2 best practice of letting the credential chain resolve at runtime.WebIdentityTokenFileCredentialsProvider.create()withDefaultCredentialsProvider.create()in the non-static-credentials branch ofgetKmsClientCompanion fix to
CloudStorageS3.java(UID2-4739).Test plan
🤖 Generated with Claude Code