-
Notifications
You must be signed in to change notification settings - Fork 9
add link id regex field to services #475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Ian-Nara
merged 4 commits into
main
from
ian-UID2-3134-add-link-id-regex-field-to-services
Jun 18, 2025
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -12,14 +12,21 @@ public class Service { | |
| private final int serviceId; | ||
| @JsonProperty("site_id") | ||
| private int siteId; | ||
| @JsonProperty("link_id_regex") | ||
| private String linkIdRegex; | ||
| private String name; | ||
| private Set<Role> roles; | ||
|
|
||
| public Service(int serviceId, int siteId, String name, Set<Role> roles) { | ||
| this(serviceId, siteId, name, roles, null); | ||
| } | ||
|
|
||
| public Service(int serviceId, int siteId, String name, Set<Role> roles, String linkIdRegex) { | ||
| this.serviceId = serviceId; | ||
| this.siteId = siteId; | ||
| this.name = name; | ||
| this.roles = Objects.requireNonNullElseGet(roles, HashSet::new); | ||
| this.linkIdRegex = linkIdRegex; | ||
| } | ||
|
|
||
| public int getServiceId() { | ||
|
|
@@ -34,6 +41,14 @@ public void setSiteId(int siteId) { | |
| this.siteId = siteId; | ||
| } | ||
|
|
||
| public String getLinkIdRegex() { | ||
| return linkIdRegex; | ||
| } | ||
|
|
||
| public void setLinkIdRegex(String linkIdRegex) { | ||
| this.linkIdRegex = linkIdRegex; | ||
| } | ||
|
|
||
| public String getName() { | ||
| return name; | ||
| } | ||
|
|
@@ -57,19 +72,25 @@ public String toString() { | |
| ", siteId=" + siteId + | ||
| ", name='" + name + '\'' + | ||
| ", roles=" + roles + | ||
| ", linkIdRegex=" + linkIdRegex + | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Would it fail when
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. no, java handles the concatenation by automatically converting null to "null" |
||
| '}'; | ||
| } | ||
|
|
||
| @Override | ||
| public boolean equals(Object o) { | ||
| if (this == o) return true; | ||
| if (o == null || getClass() != o.getClass()) return false; | ||
| Service service = (Service) o; | ||
| return serviceId == service.serviceId && siteId == service.siteId && name.equals(service.name) && roles.equals(service.roles); | ||
| Service other = (Service) o; | ||
|
|
||
| return serviceId == other.serviceId | ||
| && siteId == other.siteId | ||
| && Objects.equals(name, other.name) | ||
| && Objects.equals(roles, other.roles) | ||
| && Objects.equals(linkIdRegex, other.linkIdRegex); | ||
| } | ||
|
|
||
| @Override | ||
| public int hashCode() { | ||
| return Objects.hash(serviceId, siteId, name, roles.hashCode()); | ||
| return Objects.hash(serviceId, siteId, name, roles.hashCode(), linkIdRegex); | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.