Fix five serialization flaky tests#36
Open
pengyuejiang wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Issue
By using the plugin NonDex, 5 tests
may fail in the future due to assuming a deterministic order of fields in serialization strings. The Java specification does not guarantee such an order, yet its current implementation assumes one. This plugin shuffles the ordering of fields, which cause these tests to fail when run without the plugin. The goal of the fix is to make sure that no false alarms were made for this reason.
Reproduce Result
Here are the steps to reproduce the result:
The Fix
The current fix implemented deserializes the string and then compare them. Since these fixes rely on dependencies also used by the project, they do not introduce any new potential issues that are particular to the project itself, and can be trusted for their functionalities. The test in
SelectionConfigTypeAdapterFactoryTestwith case insensitiveness is also addressed.Please do take a look and comment on whether this is a viable approach, hope to hear back from you soon :)