Conversation
Contributor
|
@shunguo I tested in Firefox, |
philljenkins
approved these changes
Feb 5, 2025
Contributor
philljenkins
left a comment
philljenkins
left a comment
There was a problem hiding this comment.
Testing in Firefox no longer triggers the false positive
tombrunet
approved these changes
Feb 10, 2025
tombrunet
added a commit
that referenced
this pull request
Feb 10, 2025
* update the rule and add a test case #dev-2085 (#2180) Co-authored-by: Phill Jenkins <pjenkins@us.ibm.com> * fix(cypress-accessibility-checker) update links in ReadMe (#2188) * fix URL * fix all 404 links --------- Co-authored-by: Tom Brunet <thbrunet@us.ibm.com> * ACT errors with scIds (#2193) * Generate summaries on close (#2196) * chore(archive): Create archive for Feb 10, 2025 --------- Co-authored-by: Phill Jenkins <pjenkins@us.ibm.com> Co-authored-by: Shunguo Yan <shunguoy@us.ibm.com>
tombrunet
added a commit
that referenced
this pull request
Feb 18, 2025
* update the rule and add a test case #dev-2085 (#2180) Co-authored-by: Phill Jenkins <pjenkins@us.ibm.com> * fix(cypress-accessibility-checker) update links in ReadMe (#2188) * fix URL * fix all 404 links --------- Co-authored-by: Tom Brunet <thbrunet@us.ibm.com> * ACT errors with scIds (#2193) * Generate summaries on close (#2196) * chore(archive): Create archive for Feb 10, 2025 (#2197) * Add extensions * tsx files still don't use .js * avoid diff * Unnecessary change * copy over cjs mjs package.json for modules * Update gulp --------- Co-authored-by: Phill Jenkins <pjenkins@us.ibm.com> Co-authored-by: Shunguo Yan <shunguoy@us.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is related to the following issue(s):
Testing reference:
accessibility-checker-engine/tes t/v2/checker/accessibility/rules/input_label_visible_ruleunit/element_with_aria.htmlwas also added to the automated build processI have conducted the following for this PR:
Assets to aide review attached
Definition of Done