Skip to content

bug(node): File extensions not correct for ESM#2202

Merged
tombrunet merged 4 commits intomasterfrom
ext-err
Feb 18, 2025
Merged

bug(node): File extensions not correct for ESM#2202
tombrunet merged 4 commits intomasterfrom
ext-err

Conversation

@tombrunet
Copy link
Copy Markdown
Member

@tombrunet tombrunet commented Feb 17, 2025

  • Automated tool bug

This PR is related to the following issue(s):

Testing reference:

  • Not checked in, but modified the mocha-puppeteer-ts boilerplate to be a module and confirmed.

I have conducted the following for this PR:

  • I validated this code in Chrome and FF
  • I validated this fix in my local env
  • I provided details for testing
  • This PR has been reviewed and is ready for test
  • I understand that the title of this PR will be used for the next release notes.

Assets to aide review attached

  • Links to design artifacts
  • Links to video walkthrough of user experience
  • Other

Definition of Done

  • Peer review complete
  • Secondary review complete
  • Staging deployment verified

@philljenkins philljenkins added user-reported Issues identified outside of the core team and removed user-reported Issues identified outside of the core team labels Feb 17, 2025
Copy link
Copy Markdown
Contributor

@philljenkins philljenkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we list all the file.js somewhere?

@philljenkins philljenkins self-assigned this Feb 17, 2025
@tombrunet tombrunet merged commit 281d79e into master Feb 18, 2025
17 checks passed
@tombrunet tombrunet deleted the ext-err branch February 18, 2025 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG]: **All** ESM packages need .js extension

2 participants