fix(rulesets): tolerate 403 on the rulesets fetch#51
Merged
Conversation
The live e2e surfaced it: GET /orgs/{org}/rulesets 403s when the App
lacks that scope, and fetchRulesets only caught 404 — so an inaccessible
org-rulesets read aborted the whole cycle (incl. repo rulesets). Treat
403 like 404 (return empty), matching the token cycles' graceful
degradation. +1 unit test; action bundle rebuilt.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Surfaced by the live e2e:
GET /orgs/{org}/rulesets403s when the App lacks that scope (andorganization_administration: readdoesn't cover it), butfetchRulesetsonly caught 404 — so an inaccessible org-rulesets read aborted the whole rulesets cycle, including repo rulesets.Fix: treat 403 like 404 (return empty), matching how the token cycles degrade gracefully. So org-rulesets-inaccessible never blocks repo-rulesets reconciliation.
+1 unit test; action bundle rebuilt; 21 rulesets tests green.
🤖 Generated with Claude Code