Guard unsupported pipeline sample weights - #2153
Merged
FlorianPfaff merged 2 commits intoAug 10, 2026
Merged
Conversation
FlorianPfaff
marked this pull request as ready for review
August 6, 2026 05:56
FlorianPfaff
enabled auto-merge (squash)
August 6, 2026 05:57
Contributor
✅MegaLinter analysis: Success
Notices📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining See detailed reports in MegaLinter artifacts
|
Contributor
auto-merge was automatically disabled
August 9, 2026 15:59
Pull request was closed
FlorianPfaff
enabled auto-merge (squash)
August 9, 2026 16:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What changed
Pipelineestimators when their final estimator explicitly acceptssample_weight.StandardScaler→KNeighborsClassifierinstead of forwarding an unsupported keyword and failing duringfit().Root cause
The runtime adapter wrapped every pipeline whenever
sample_weightwas supplied. Itsfit()method then unconditionally forwarded<final_step>__sample_weight, even when the final estimator did not expose that parameter. This bypassed the capability check already used by the core random-subspace implementation.Validation