Reject complex observation ensemble controls - #2155
Merged
FlorianPfaff merged 2 commits intoAug 10, 2026
Merged
Conversation
Contributor
✅MegaLinter analysis: Success
Notices📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining See detailed reports in MegaLinter artifacts
|
Contributor
FlorianPfaff
marked this pull request as ready for review
August 7, 2026 16:52
FlorianPfaff
enabled auto-merge (squash)
August 7, 2026 16:52
auto-merge was automatically disabled
August 9, 2026 16:00
Pull request was closed
FlorianPfaff
enabled auto-merge (squash)
August 9, 2026 16:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Root cause
The observation-ensemble implementation converted several programmatic controls with
np.asarray(..., dtype=float)orfloat(...). NumPy complex scalars are accepted by those conversions with a warning while their imaginary component is discarded. A configuration such assource_temperatures=(np.complex128(1 + 2j), 1.0)therefore ran as(1.0, 1.0)and recorded only the narrowed real values.The same silent narrowing affected ensemble weights, probability-row tolerance, and baseline-window endpoints. This could execute a scientifically different configuration without a deterministic input error.
Impact
Malformed complex controls now fail before probability alignment or baseline computation. Ordinary Python/NumPy real scalars, arrays, tuples, and existing Boolean normalization retain their behavior.
Validation
main;github.comthrough DNS.