Skip to content

New GetDatasetUserPermissions use case, and extension of GetFileUserPermissions and GetDataset use cases#98

Merged
GPortas merged 22 commits intodevelopfrom
96-get-dataset-user-permissions
Nov 2, 2023
Merged

New GetDatasetUserPermissions use case, and extension of GetFileUserPermissions and GetDataset use cases#98
GPortas merged 22 commits intodevelopfrom
96-get-dataset-user-permissions

Conversation

@GPortas
Copy link
Copy Markdown
Contributor

@GPortas GPortas commented Oct 18, 2023

What this PR does / why we need it:

Adds new use case GetDatasetUserPermissions

Extends existing use cases:

  • GetFileUserPermissions: To include canManageFilePermissions check
  • Deaccessioned support to getDataset use case (Optional includeDeaccessioned param)

Which issue(s) this PR closes:

Related Dataverse PRs:

Depends on:

Suggestions on how to test this:

  • Visual inspection of the code
  • Check unit and integration tests execution in GitHub actions

Is there a release notes update needed for this change?:

N/A

Additional documentation:

None

@GPortas GPortas changed the base branch from develop to 94-total-file-download-size-with-criteria October 18, 2023 11:02
@GPortas GPortas changed the title 96 get dataset user permissions New GetDatasetUserPermissions use case, and extension of GetFileUserPermissions and GetDataset use cases Oct 18, 2023
@GPortas GPortas marked this pull request as ready for review October 18, 2023 14:56
@GPortas GPortas added the Size: 3 A percentage of a sprint. 2.1 hours. label Oct 26, 2023
Base automatically changed from 94-total-file-download-size-with-criteria to 90-file-counts-criteria October 26, 2023 23:12
@MellyGray MellyGray self-assigned this Oct 31, 2023
@MellyGray
Copy link
Copy Markdown
Contributor

@GPortas can you check the base branch? I think the branch for file counts criteria should be already merged into develop since the related PR was closed

MellyGray
MellyGray previously approved these changes Oct 31, 2023
Copy link
Copy Markdown
Contributor

@MellyGray MellyGray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Can you review the base branch ? I think 90-file-counts-criteria should had been merged into develop when the associated PR was closed

@MellyGray MellyGray removed their assignment Oct 31, 2023
@GPortas GPortas changed the base branch from 90-file-counts-criteria to develop November 1, 2023 12:49
@GPortas GPortas dismissed MellyGray’s stale review November 1, 2023 12:49

The base branch was changed.

@GPortas GPortas self-assigned this Nov 2, 2023
@GPortas
Copy link
Copy Markdown
Contributor Author

GPortas commented Nov 2, 2023

Tests fail due to a known FilesRepository issue that will be addressed in: #101

I've decided to temporarily skip this test in the code until we fix it to avoid breaking the package build and GPR push in the GitHub action.

We will reactivate the test once we fix it in #101.

@GPortas GPortas merged commit aa356a3 into develop Nov 2, 2023
@GPortas GPortas deleted the 96-get-dataset-user-permissions branch November 2, 2023 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Size: 3 A percentage of a sprint. 2.1 hours.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create use case for obtaining Dataset user permissions

2 participants