Skip to content

[WIP] Revert formatting and whitespace changes in PR #11745#11899

Closed
Copilot wants to merge 1 commit intodevelopfrom
copilot/revert-formatting-changes
Closed

[WIP] Revert formatting and whitespace changes in PR #11745#11899
Copilot wants to merge 1 commit intodevelopfrom
copilot/revert-formatting-changes

Conversation

Copy link

Copilot AI commented Oct 14, 2025

Revert Formatting and Whitespace Changes in PR #11745

This PR reverts all formatting and whitespace changes made in PR #11745 (branch: 11744-cors-echo-origin-vary) while preserving all actual code/content changes.

Completed:

  • Analyze PR 11744 CORS: echo request Origin + add Vary #11745 to identify all files touched
  • Identify files with only formatting changes vs. actual code changes
  • Create script to restore trailing whitespace from develop branch
  • Process all modified files to restore original whitespace patterns
  • For each file with code changes, restore original formatting from develop branch while keeping code changes:
    • src/main/java/edu/harvard/iq/dataverse/DatasetFieldServiceBean.java (code + formatting restored)
    • src/main/java/edu/harvard/iq/dataverse/FileMetadata.java (code + formatting restored)
    • src/main/java/edu/harvard/iq/dataverse/SettingsWrapper.java (code + formatting restored)
    • src/main/java/edu/harvard/iq/dataverse/api/Admin.java (code + formatting restored)
    • src/main/java/edu/harvard/iq/dataverse/api/Datasets.java (code + formatting restored)
    • src/main/java/edu/harvard/iq/dataverse/batch/jobs/importer/filesystem/FileRecordReader.java (code + formatting restored)
    • src/main/java/edu/harvard/iq/dataverse/dataaccess/GlobusAccessibleStore.java (code + formatting restored)
    • src/main/java/edu/harvard/iq/dataverse/dataaccess/GlobusOverlayAccessIO.java (code + formatting restored)
    • src/main/java/edu/harvard/iq/dataverse/dataaccess/RemoteOverlayAccessIO.java (code + formatting restored)
    • src/main/java/edu/harvard/iq/dataverse/datacapturemodule/DataCaptureModuleUtil.java (code + formatting restored)
    • src/main/java/edu/harvard/iq/dataverse/dataset/DatasetUtil.java (code + formatting restored)
    • src/main/java/edu/harvard/iq/dataverse/engine/command/impl/CreateDataverseCommand.java (code + formatting restored)
    • src/main/java/edu/harvard/iq/dataverse/filter/CorsFilter.java (code + formatting restored)
    • src/main/java/edu/harvard/iq/dataverse/pidproviders/AbstractPidProvider.java (code + formatting restored)
    • src/main/java/edu/harvard/iq/dataverse/pidproviders/PidProviderFactoryBean.java (code + formatting restored)
    • src/main/java/edu/harvard/iq/dataverse/settings/JvmSettings.java (code + formatting restored)
    • src/main/java/edu/harvard/iq/dataverse/util/CSLUtil.java (code + formatting restored)
    • src/main/java/edu/harvard/iq/dataverse/util/SystemConfig.java (code + formatting restored)
    • src/main/java/edu/harvard/iq/dataverse/workflow/internalspi/LDNAnnounceDatasetVersionStep.java (code + formatting restored)
    • src/test/java/edu/harvard/iq/dataverse/export/ddi/DdiExportUtilTest.java (code + formatting restored)
    • src/test/java/edu/harvard/iq/dataverse/pidproviders/PidUtilTest.java (code + formatting restored)
  • Keep new files from PR (these are intentional additions):
    • doc/release-notes/11744-cors-echo-origin-vary.md
    • src/main/java/edu/harvard/iq/dataverse/util/ListSplitUtil.java
    • src/test/java/edu/harvard/iq/dataverse/filter/CorsFilterTest.java
    • src/test/java/edu/harvard/iq/dataverse/util/ListSplitUtilTest.java
  • Handle documentation files (keeping content changes, reverting formatting):
    • doc/sphinx-guides/source/api/external-tools.rst
    • doc/sphinx-guides/source/developers/big-data-support.rst
    • doc/sphinx-guides/source/installation/config.rst
    • doc/sphinx-guides/source/user/dataset-management.rst
  • Verify the result shows only intentional changes
  • Run tests to ensure no breakage

Next Steps:

  • Verify compilation and run tests
  • Review final diff to ensure only code changes remain
Original prompt

Revert all formatting and whitespace changes in all files touched by PR #11745 (branch: 11744-cors-echo-origin-vary) so that only the intentional code/content changes remain. Restore indentation, spacing, line endings, and blank lines to match the develop branch in all files, except where such changes are required for code correctness (e.g., changes necessary for parsing or syntax). Do not revert any actual code or content changes. The result should make the diff show only the real code changes, removing all unintentional formatting noise from the PR.

This pull request was created as a result of the following prompt from Copilot chat.

Revert all formatting and whitespace changes in all files touched by PR #11745 (branch: 11744-cors-echo-origin-vary) so that only the intentional code/content changes remain. Restore indentation, spacing, line endings, and blank lines to match the develop branch in all files, except where such changes are required for code correctness (e.g., changes necessary for parsing or syntax). Do not revert any actual code or content changes. The result should make the diff show only the real code changes, removing all unintentional formatting noise from the PR.


💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.

@ErykKul ErykKul closed this Oct 14, 2025
@ErykKul ErykKul deleted the copilot/revert-formatting-changes branch October 14, 2025 16:08
Copilot AI requested a review from ErykKul October 14, 2025 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants