Skip to content

Fix timing issue when posting guestbook response and requesting the d…#12341

Merged
sekmiller merged 1 commit intodevelopfrom
12340-timing-issue-guestbook-response
Apr 27, 2026
Merged

Fix timing issue when posting guestbook response and requesting the d…#12341
sekmiller merged 1 commit intodevelopfrom
12340-timing-issue-guestbook-response

Conversation

@stevenwinship
Copy link
Copy Markdown
Contributor

@stevenwinship stevenwinship commented Apr 20, 2026

Which issue(s) this PR closes:#12340

Special notes for your reviewer:

Suggestions on how to test this: post guestbook response. loop calling api with signed url to make sure you can call download within the minute

[edit:] The old/incorrect behavior, currently in the develop branch:
0-10 sec.: the signed url is working as it should;
11-60 sec.: error message "you may not download this file without the required Guestbook response ..." (??)
60+sec: signed url expires.
[/edit - L.A.]

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?:

Additional documentation:

@stevenwinship stevenwinship self-assigned this Apr 20, 2026
@stevenwinship stevenwinship moved this to In Progress 💻 in IQSS Dataverse Project Apr 20, 2026
@stevenwinship stevenwinship added FY26 Sprint 21 FY26 Sprint 21 (2026-04-08 - 2026-04-22) Size: 3 A percentage of a sprint. 2.1 hours. Type: Bug a defect labels Apr 20, 2026
@stevenwinship stevenwinship added this to the 6.11 milestone Apr 20, 2026
@coveralls
Copy link
Copy Markdown

coveralls commented Apr 20, 2026

Coverage Status

coverage: 24.887%. remained the same — 12340-timing-issue-guestbook-response into develop

@github-actions

This comment has been minimized.

@stevenwinship stevenwinship removed their assignment Apr 20, 2026
@stevenwinship stevenwinship moved this from In Progress 💻 to Ready for Review ⏩ in IQSS Dataverse Project Apr 20, 2026
@stevenwinship stevenwinship force-pushed the 12340-timing-issue-guestbook-response branch from f8514a4 to c3959ae Compare April 20, 2026 22:16
@github-actions

This comment has been minimized.

@stevenwinship stevenwinship force-pushed the 12340-timing-issue-guestbook-response branch from c3959ae to a85e23f Compare April 21, 2026 15:21
@github-actions

This comment has been minimized.

@cmbz cmbz added the FY26 Sprint 22 FY26 Sprint 22 (2026-04-22 - 2026-05-06) label Apr 22, 2026
@landreev landreev moved this from Ready for Review ⏩ to In Review 🔎 in IQSS Dataverse Project Apr 23, 2026
@landreev landreev self-assigned this Apr 23, 2026
@landreev landreev self-requested a review April 23, 2026 15:42
@stevenwinship stevenwinship force-pushed the 12340-timing-issue-guestbook-response branch from a85e23f to d0d1f3b Compare April 23, 2026 15:42
@github-actions

This comment has been minimized.

Copy link
Copy Markdown
Contributor

@landreev landreev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense overall. Should we make it a jvm setting, and configurable, in seconds? - Although I suspect that 1 min. will just work for everybody.

@landreev
Copy link
Copy Markdown
Contributor

Makes sense overall. Should we make it a jvm setting, and configurable, in seconds? - Although I suspect that 1 min. will just work for everybody.

Your call really. Happy to approve as soon as I hear back either way.

Copy link
Copy Markdown
Contributor

@landreev landreev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... or I can just approve. If/when someone has a practical need to reduce, or increase this lifespan, we'll deal with it.

@github-project-automation github-project-automation Bot moved this from In Review 🔎 to Ready for QA ⏩ in IQSS Dataverse Project Apr 24, 2026
@landreev landreev removed their assignment Apr 24, 2026
@landreev
Copy link
Copy Markdown
Contributor

The Jenkins failure is an aws fluke - ?

@landreev
Copy link
Copy Markdown
Contributor

The Jenkins failure is an aws fluke - ?

Not an "aws fluke", but

TASK [dataverse : download custom maven version] *******************************
fatal: [localhost]: FAILED! => {"changed": false, "dest": "/tmp/apache-maven-3.9.14-bin.tar.gz", "elapsed": 0, "msg": "Request failed", "response": "HTTP Error 404: Not Found", "status_code": 404, "url": "http://mirrors.ibiblio.org/apache/maven/maven-3/3.9.14/binaries/apache-maven-3.9.14-bin.tar.gz"}

still, for reasons unrelated to/before it gets to the tests.

@landreev
Copy link
Copy Markdown
Contributor

OK, Jenkins tests passed. (thanks @donsizemore!)

@stevenwinship stevenwinship force-pushed the 12340-timing-issue-guestbook-response branch from d0d1f3b to 353c383 Compare April 27, 2026 13:11
@github-actions
Copy link
Copy Markdown

📦 Pushed preview images as

ghcr.io/gdcc/dataverse:12340-timing-issue-guestbook-response
ghcr.io/gdcc/configbaker:12340-timing-issue-guestbook-response

🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name.

@sekmiller sekmiller self-assigned this Apr 27, 2026
@sekmiller sekmiller moved this from Ready for QA ⏩ to QA ✅ in IQSS Dataverse Project Apr 27, 2026
@sekmiller sekmiller merged commit a0cf2ef into develop Apr 27, 2026
20 checks passed
@github-project-automation github-project-automation Bot moved this from QA ✅ to Merged 🚀 in IQSS Dataverse Project Apr 27, 2026
@scolapasta scolapasta moved this from Merged 🚀 to Done 🧹 in IQSS Dataverse Project Apr 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

FY26 Sprint 21 FY26 Sprint 21 (2026-04-08 - 2026-04-22) FY26 Sprint 22 FY26 Sprint 22 (2026-04-22 - 2026-05-06) Size: 3 A percentage of a sprint. 2.1 hours. Type: Bug a defect

Projects

Status: Done 🧹

Development

Successfully merging this pull request may close these issues.

BUG: Timing constrain issue between posting guestbook response and downloading file

7 participants