Adding filtering and pagination to collectionList APIs - #12436
Open
stevenwinship wants to merge 19 commits into
Open
Adding filtering and pagination to collectionList APIs#12436stevenwinship wants to merge 19 commits into
stevenwinship wants to merge 19 commits into
Conversation
This comment has been minimized.
This comment has been minimized.
Test Results404 tests 389 ✅ 25m 16s ⏱️ Results for commit e737ac1. ♻️ This comment has been updated with latest results. |
stevenwinship
force-pushed
the
12423-collection-list-search-and-pagination
branch
from
June 8, 2026 13:32
5a0bf16 to
c73b373
Compare
This comment has been minimized.
This comment has been minimized.
stevenwinship
force-pushed
the
12423-collection-list-search-and-pagination
branch
from
June 9, 2026 20:07
c73b373 to
eca44a4
Compare
This comment has been minimized.
This comment has been minimized.
stevenwinship
force-pushed
the
12423-collection-list-search-and-pagination
branch
from
June 15, 2026 18:36
eca44a4 to
6c33308
Compare
This comment has been minimized.
This comment has been minimized.
stevenwinship
force-pushed
the
12423-collection-list-search-and-pagination
branch
from
June 15, 2026 21:19
6c33308 to
98baff1
Compare
This comment has been minimized.
This comment has been minimized.
stevenwinship
force-pushed
the
12423-collection-list-search-and-pagination
branch
from
June 22, 2026 17:42
98baff1 to
e166e23
Compare
This comment has been minimized.
This comment has been minimized.
stevenwinship
force-pushed
the
12423-collection-list-search-and-pagination
branch
from
July 2, 2026 13:14
e166e23 to
e1391a1
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Member
|
At standup we talked about how we have various patterns for pagination, which I wrote about here: cfc5301
@stevenwinship will try to switch to the "A" family that the frontend expects. Also, there's a Pager.java class at https://github.com/IQSS/dataverse/blob/v6.11/src/main/java/edu/harvard/iq/dataverse/mydata/Pager.java . We might want to create a new Pager class to rule them all. 💍 |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
|
📦 Pushed preview images as 🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


What this PR does / why we need it: Result lists for collections can be quite large so a way to filter and use pagination is needed.
Which issue(s) this PR closes:#12423
Special notes for your reviewer: Switched to family "A" pagination. I did not change the output from "data.items" to "data" since that would be a breaking api change and data also contains count and totalCount.
Suggestions on how to test this: See DataRetrieverApi tests. create many dataverses owned or given access to a user. Test getting the list with and without pagination. Get the list as a superuser. Filter the list with a sort term.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?: included
Additional documentation:
https://dataverse-guide--12436.org.readthedocs.build/en/12436/api/native-api.html#list-dataverse-collections-a-user-can-act-on-based-on-their-permissions