Skip to content

bump awssdk netty-codec - #12593

Open
donsizemore wants to merge 2 commits into
developfrom
135_bump_awssdk_netty-codec
Open

bump awssdk netty-codec#12593
donsizemore wants to merge 2 commits into
developfrom
135_bump_awssdk_netty-codec

Conversation

@donsizemore

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

bump AWSSDK from 2.33.0 to 2.49.0 in order to bump various inclusions of netty-codec

Which issue(s) this PR closes:

Special notes for your reviewer:

errantly included a commit from a previous PR which is hopefully an easier merge

Suggestions on how to test this:

all things AWS

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

no

Is there a release notes update needed for this change?:

AWSSDK is a pretty big component of Dataverse, so it might be worth mentioning?

Additional documentation:

none

@donsizemore
donsizemore requested a review from qqmyers August 7, 2026 20:17
@pdurbin pdurbin moved this to Ready for Triage in IQSS Dataverse Project Aug 7, 2026
@coveralls

Copy link
Copy Markdown

Coverage Status

coverage: 25.002%. remained the same — 135_bump_awssdk_netty-codec into develop

@qqmyers qqmyers left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. #12498 has similar updates (and many others), but is already behind this PR.

@github-project-automation github-project-automation Bot moved this from Ready for Triage to Ready for QA ⏩ in IQSS Dataverse Project Aug 7, 2026
@sonarqubecloud

sonarqubecloud Bot commented Aug 7, 2026

Copy link
Copy Markdown

@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown

📦 Pushed preview images as

ghcr.io/gdcc/dataverse:135-bump-awssdk-netty-codec
ghcr.io/gdcc/configbaker:135-bump-awssdk-netty-codec

🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name.

@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown

Test Results

400 tests   - 3   383 ✅  - 5   33m 28s ⏱️ + 7m 59s
 55 suites ±0    15 💤 ±0 
 55 files   ±0     1 ❌ +1   1 🔥 +1 

For more details on these failures and errors, see this check.

Results for commit f82dc7e. ± Comparison against base commit 66f3013.

This pull request removes 4 and adds 1 tests. Note that renamed tests count towards both.
edu.harvard.iq.dataverse.api.S3AccessIT ‑ testDirectUpload
edu.harvard.iq.dataverse.api.S3AccessIT ‑ testDirectUploadDetectStataFile
edu.harvard.iq.dataverse.api.S3AccessIT ‑ testDirectUploadWithFileCountLimit
edu.harvard.iq.dataverse.api.S3AccessIT ‑ testNonDirectUpload
edu.harvard.iq.dataverse.api.S3AccessIT ‑ Unknown test

@cmbz cmbz added FY27 Sprint 3 FY27 Sprint 3 (2026-07-29 - 2026-08-12) FY27 Sprint 4 FY27 Sprint 4 (2026-08-12 - 2026-08-26) labels Aug 12, 2026
@pdurbin pdurbin moved this from Ready for QA ⏩ to In Review 🔎 in IQSS Dataverse Project Aug 12, 2026

@pdurbin pdurbin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A quick review.

Comment thread pom.xml
<tika.version>3.2.2</tika.version>
<tika.version>3.3.2</tika.version>
<netcdf.version>5.9.1</netcdf.version>

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@donsizemore thanks for the PR. Tests are failing:

Image

Can you please try to get them passing?

@pdurbin pdurbin added this to the 6.12 milestone Aug 12, 2026
@qqmyers

qqmyers commented Aug 12, 2026

Copy link
Copy Markdown
Member

There's a test fix in #12498 which is now using a later netty/aws than this. I'm not sure about the http client issue - I haven't seen it in #12498 (and the tests aren't running in github yet due to the payara change), but it has many library updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

FY27 Sprint 3 FY27 Sprint 3 (2026-07-29 - 2026-08-12) FY27 Sprint 4 FY27 Sprint 4 (2026-08-12 - 2026-08-26)

Projects

Status: In Review 🔎

Development

Successfully merging this pull request may close these issues.

5 participants