9307 convert inline tables to csv generated tables#9308
Closed
kuhlaid wants to merge 27 commits intoIQSS:developfrom
Closed
9307 convert inline tables to csv generated tables#9308kuhlaid wants to merge 27 commits intoIQSS:developfrom
kuhlaid wants to merge 27 commits intoIQSS:developfrom
Conversation
added 26 commits
January 17, 2023 18:07
Member
|
@kuhlaid hi! I'm closing this pull request in favor of this one: I realize my fix is much less ambitious than yours but in practice we've found that smaller chunks of work move more easily through the system. I hope you continue to engage and help us improve the PDF! As I mentioned In that PR, we are now building it regularly (every time a PR is merged) at http://preview.guides.gdcc.io/_/downloads/en/develop/pdf/ I'm going to repeat this comment on your other open related PRs. Sorry! 😅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: Table formatting in the documentation can be a nightmare if tables are entered inline. In the PDF documentation, long tables will be truncated at the end of the page where the table begins and will not wrap to the subsequent pages. Using csv tables with the
:class: longtableoption fixes this issue for PDF builds of the documentation. Many of the large tables were converted to csv tables in this version of the documentation.Which issue(s) this PR closes: #9307