add information about curl -F option without outer quote #4510#9654
Merged
kcondon merged 6 commits intoIQSS:developfrom Jun 23, 2023
KimJinYeon:develop
Merged
add information about curl -F option without outer quote #4510#9654kcondon merged 6 commits intoIQSS:developfrom KimJinYeon:develop
kcondon merged 6 commits intoIQSS:developfrom
KimJinYeon:develop
Conversation
What this PR does / why we need it: Add information about problem with curl -F option without outer quote for curl 7.56.0 and higher versions. #4510 Which issue(s) this PR closes: #4510 Special notes for your reviewer: None. Suggestions on how to test this: None. Does this PR introduce a user interface change? If mockups are available, please link/include them here: No. Is there a release notes update needed for this change?: No. Additional documentation:
add information about curl -F option without outer quote #4510
pdurbin
reviewed
Jun 19, 2023
Member
pdurbin
left a comment
pdurbin
left a comment
There was a problem hiding this comment.
According to the man page, it should be "form" not "from".
fix --form-string to --from-string Co-authored-by: Philip Durbin <philipdurbin@gmail.com>
fix --form-string to --from-string Co-authored-by: Philip Durbin <philipdurbin@gmail.com>
fix --form-string to --from-string
KimJinYeon
commented
Jun 19, 2023
pdurbin
reviewed
Jun 20, 2023
|
|
||
| echo $SERVER_URL | ||
|
|
||
| With curl version 7.56.0 and higher, it is recommended to use --from-string with outer quote rather than -F flag without outer quote. |
Member
There was a problem hiding this comment.
Suggested change
| With curl version 7.56.0 and higher, it is recommended to use --from-string with outer quote rather than -F flag without outer quote. | |
| With curl version 7.56.0 and higher, it is recommended to use --form-string with outer quote rather than -F flag without outer quote. |
|
|
||
| -F jsonData={\"description\":\"My description.\",\"categories\":[\"Data\"]} | ||
|
|
||
| Instead, use --from-string with outer quote. See https://github.com/curl/curl/issues/2022 |
Member
There was a problem hiding this comment.
Suggested change
| Instead, use --from-string with outer quote. See https://github.com/curl/curl/issues/2022 | |
| Instead, use --form-string with outer quote. See https://github.com/curl/curl/issues/2022 |
|
|
||
| .. code-block:: bash | ||
|
|
||
| --from-string 'jsonData={"description":"My description.","categories":["Data"]}' |
Member
There was a problem hiding this comment.
Suggested change
| --from-string 'jsonData={"description":"My description.","categories":["Data"]}' | |
| --form-string 'jsonData={"description":"My description.","categories":["Data"]}' |
Contributor
Author
There was a problem hiding this comment.
@pdurbin
Right. Sorry. I totally misunderstood.
Now I fixed it!
pdurbin
approved these changes
Jun 22, 2023
Member
pdurbin
left a comment
pdurbin
left a comment
There was a problem hiding this comment.
https://dataverse-guide--9654.org.readthedocs.build/en/9654/api/getting-started.html#curl-examples-and-environment-variables looks good to me.
Thanks, @KimJinYeon! Approved!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Add information about problem with curl -F option without outer quote for curl 7.56.0 and higher versions.
Which issue(s) this PR closes:
Closes #4510
Special notes for your reviewer:
None.
Suggestions on how to test this:
None.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
No.
Is there a release notes update needed for this change?:
No.
Additional documentation: