A static 404 page (9770) - #9856
Conversation
…hrowing errors under p6 on account of some conflict with prettyfaces rewrite. (#9770)
This comment has been minimized.
This comment has been minimized.
pdurbin
left a comment
pdurbin
left a comment
There was a problem hiding this comment.
Just some quick feedback. I don't mean to hold up this PR. I think it can be tested as-is.
| <!DOCTYPE html> | ||
| <html xmlns="http://www.w3.org/1999/xhtml" xmlns:h="http://java.sun.com/jsf/html" lang="en"> | ||
| <head> | ||
| <title>Dataverse - Not Found</title> |
There was a problem hiding this comment.
I'm seeing some hard coded English on this page. Should we be using something like..
#{bundle['error.404.page.title']}
here? And other bundle entries from the old 404.xhtml?
There was a problem hiding this comment.
Sure, why not.
The words "copyright ..." etc. should be ok to stay hard-coded in English though.
| <div class="container"> | ||
| <div class="row"> | ||
| <div class="col-sm-8 small"> | ||
| <p>Copyright © 2023, The President & Fellows of Harvard College | <a href="http://best-practices.dataverse.org/harvard-policies/harvard-privacy-policy.html" target="_blank">Privacy Policy</a> |
There was a problem hiding this comment.
I guess we can't have anything dynamic like this:
value="#{settingsWrapper.get(':ApplicationPrivacyPolicyUrl')}"
…e. Replaced them with the more neutral "Dataverse Project") #9770
|
Here's what it looks like: |
This comment has been minimized.
This comment has been minimized.
1 similar comment
|
📦 Pushed preview images as 🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name. |
pdurbin
left a comment
pdurbin
left a comment
There was a problem hiding this comment.
I didn't run this but the code makes sense. Approved.
3 participants
What this PR does / why we need it:
This static page replaces the way-too-dynamic 404.xhtml page that's been throwing errors under p6 on account of some conflict with prettyfaces rewrite.
It's a rather confusing affair. I will add some details to the issue, spelling out just how confusing it is. Which will take more time than it took to put together this replacement page - which by itself should be a good reason to go with it.
Which issue(s) this PR closes:
Closes #9770
Special notes for your reviewer:
Suggestions on how to test this:
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: