Skip to content
This repository was archived by the owner on Apr 14, 2025. It is now read-only.

Fix ambiguity errors caused by BlockArrays.jl v1.4 - #12

Merged
mtfishman merged 1 commit into
mainfrom
fix_ambiguities
Feb 6, 2025
Merged

Fix ambiguity errors caused by BlockArrays.jl v1.4#12
mtfishman merged 1 commit into
mainfrom
fix_ambiguities

Conversation

@mtfishman

Copy link
Copy Markdown
Member

Fix ambiguity errors caused by JuliaArrays/BlockArrays.jl#445.

Fixes test failures seen in ITensor/BlockSparseArrays.jl#39.

@ogauthe @lkdvos

@codecov

codecov Bot commented Feb 6, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.84%. Comparing base (2b1f451) to head (cb8b502).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##            main      #12       +/-   ##
==========================================
+ Coverage   0.00%   76.84%   +76.84%     
==========================================
  Files          7        8        +1     
  Lines        368      380       +12     
==========================================
+ Hits           0      292      +292     
+ Misses       368       88      -280     
Flag Coverage Δ
docs 0.00% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lkdvos

lkdvos commented Feb 6, 2025

Copy link
Copy Markdown
Contributor

Do you know what happens if you turn on the ambiguity tests in Aqua? Or is that still too much of a large list to reasonably fix

@mtfishman

Copy link
Copy Markdown
Member Author

Do you know what happens if you turn on the ambiguity tests in Aqua? Or is that still too much of a large list to reasonably fix

Good question, I just ran it locally and it is really long, but I think it isn't worth looking into now since a lot will change with the SectorUnitRange redesign.

@mtfishman
mtfishman merged commit 4ae7cf7 into main Feb 6, 2025
@mtfishman
mtfishman deleted the fix_ambiguities branch February 6, 2025 20:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants