Skip to content

IntegrationTest: catch ResolverError for URL-based downstreams #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mtfishman merged 1 commit into from
Apr 23, 2026
Merged

IntegrationTest: catch ResolverError for URL-based downstreams #80

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 16 additions & 16 deletions .github/workflows/IntegrationTest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,15 +79,15 @@ jobs:
end
end
pkg = "${{ inputs.pkg }}"
if startswith(pkg, "https://") || startswith(pkg, "git@")
# URL: unregistered or private package, skip version-pinning.
pkg_name = replace(basename(pkg), r"\.jl$" => "")
Pkg.add(PackageSpec(; url=pkg))
Pkg.develop(PackageSpec(; path="."))
Pkg.update()
Pkg.test(PackageSpec(; name=pkg_name))
else
try
try
if startswith(pkg, "https://") || startswith(pkg, "git@")
# URL: unregistered or private package, skip version-pinning.
pkg_name = replace(basename(pkg), r"\.jl$" => "")
Pkg.add(PackageSpec(; url=pkg)) # resolver may fail with main deps
Pkg.develop(PackageSpec(; path=".")) # resolver may fail with main deps
Pkg.update()
Pkg.test(PackageSpec(; name=pkg_name)) # resolver may fail with test time deps
else
Pkg.add(PackageSpec(; name=pkg))
# Determine the version that gets installed in order to detect
# if the package is forced to downgrade.
Expand All @@ -100,12 +100,12 @@ jobs:
# to see if there is a compatibility issue.
Pkg.add(PackageSpec(; name=pkg, version=version))
Pkg.test(PackageSpec(; name=pkg)) # resolver may fail with test time deps
catch err
err isa Pkg.Resolve.ResolverError || rethrow()
# If we can't resolve that means this is incompatible by SemVer and this is fine
# It means we marked this as a breaking change, so we don't need to worry about
# Mistakenly introducing a breaking change, as we have intentionally made one
@info "Not compatible with this release. No problem." exception=err
exit(0) # Exit immediately, as a success
end
catch err
err isa Pkg.Resolve.ResolverError || rethrow()
# If we can't resolve that means this is incompatible by SemVer and this is fine
# It means we marked this as a breaking change, so we don't need to worry about
# Mistakenly introducing a breaking change, as we have intentionally made one
@info "Not compatible with this release. No problem." exception=err
exit(0) # Exit immediately, as a success
end