This repository was archived by the owner on Jan 20, 2025. It is now read-only.
Moving remaining implementations in PEPSAD.jl to the lib - #10
Merged
Conversation
…-16-00-07-26-714-2307884933 CompatHelper: add new compat entry for "Zygote" at version "0.6"
…-16-00-07-20-996-3139195681 CompatHelper: add new compat entry for "OptimKit" at version "0.3"
mtfishman
reviewed
Jul 16, 2021
mtfishman
reviewed
Jul 16, 2021
mtfishman
reviewed
Jul 16, 2021
mtfishman
reviewed
Jul 16, 2021
mtfishman
reviewed
Jul 16, 2021
mtfishman
reviewed
Jul 16, 2021
mtfishman
reviewed
Jul 16, 2021
mtfishman
reviewed
Jul 16, 2021
mtfishman
reviewed
Jul 16, 2021
mtfishman
reviewed
Jul 16, 2021
mtfishman
reviewed
Jul 16, 2021
mtfishman
reviewed
Jul 16, 2021
mtfishman
reviewed
Jul 16, 2021
mtfishman
reviewed
Jul 16, 2021
mtfishman
reviewed
Jul 16, 2021
Member
|
Thanks Linjian, I think the organization is good and we can always circle back to it later once the functionality is more developed. |
Collaborator
Author
Thanks for the comments! I will work on these soon |
Collaborator
Author
|
@mtfishman sorry for being a bit slow on this, I was distracted by some other stuff. This PR looks good for me now, let me know if you have other comments. |
Member
|
Looks good, thanks Linjian! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.