This repository was archived by the owner on Jan 20, 2025. It is now read-only.
Rewrite models based on Square struct, add LineMPO struct - #30
Merged
Conversation
mtfishman
reviewed
Aug 3, 2021
mtfishman
reviewed
Aug 3, 2021
| ] | ||
| end | ||
|
|
||
| function bonds(lattice::Square, coord::Tuple{Colon,<:Integer}) |
Member
There was a problem hiding this comment.
This is useful functionality!
In general what we could do is make this more generic, where you could ask for a general (hypercubic) slice of a HyperCubic lattice type and then ask for the bonds of that slice. But totally fine to have more specialized functions like this for now.
Member
|
Looks good, glad you were able to fix the bond iteration for the I think ideally we wouldn't have two different types We should make issues reminding us to:
|
This was referenced Aug 3, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change the hamiltonians in the PEPS optimization experiments such that each local hamiltonian is a column/row of the overall H.