fix/notification-command-inherited-fields-missing refs #2286

[moreamazingnick]

Icinga director has different relations for Checks and Notifications but references the same db-table
for checks: check_command
for notifications: command

IcingaObjectfield loader only checks relation check_command

[moreamazingnick]

seems to be more complicated since the var resolver doesnt involve inheritance from a notification command. but the inheritance works

[moreamazingnick]

If we patch protected function eventuallyGetResolvedCommandVar(IcingaObject $object, $varName) ind DIrectorDatafield the resolver works works fine.

@Thomas-Gelf Please tell me if I should prepare another merge request, or if this inheritance behaviour is not a bug but a feature

[lippserd]

@moreamazingnick can you please reset your branch to master and reapply your change and then do a force push?

@raviks789 please check this PR.

[raviks789]

@lippserd I am not sure I understand the issue and why this change is required. It would nice if there are screenshots of the issue or steps to reproduce the issue.

[moreamazingnick]

@raviks789
If a notification template uses a notificationcommand the command fields are not present like in a servicetemplate
they have to be maually added.

without the patch:

• create notification template
• add notificationcommand
• no fields

with the patch:

• create notification template
• add notificationcommand
• all fields from the notificationcommand fields
  Best regards
  Nicolas

[raviks789]

Icinga director has different relations for Checks and Notifications but references the same db-table for checks: check_command for notifications: command

IcingaObjectfield loader only checks relation check_command

I think there is some confusion here. NotificationCommand object is not the same as Notification object. Notification commands help to configure how the notifications are sent. Please refer the documentation on notification commands and notifications for more detail.

When the template created for NotificationCommand, is used to create NotificationCommand object then the custom vars are properly inherited by that command. You can then use this command in the Notification object.

To create the notification command object. You have to navigate to Commands section and add a new command of type Notification Plugin Command and import the command template you have created.

Hence, this change which is trying to inherit the custom vars of the notification command template in a notification object is not necessary.

[moreamazingnick]

If I create a host or service template and import a command the template shows me all the fields the command has to offer.
since the has relation searches for a "check_command" releation this does not work in the notification context which uses a command relation.

best regards
Nicolas