Conversation
Codecov Report
@@ Coverage Diff @@
## main #94 +/- ##
==========================================
+ Coverage 77.71% 77.72% +0.01%
==========================================
Files 41 41
Lines 4316 4318 +2
Branches 835 836 +1
==========================================
+ Hits 3354 3356 +2
Misses 701 701
Partials 261 261
Continue to review full report at Codecov.
|
peppelinux
force-pushed
the
peppelinux-patch-1
branch
2 times, most recently
from
25f836f to
f3febc6
Compare
peppelinux
commented
Oct 10, 2021
|
|
||
| self.httpc_params = httpc_params or {} | ||
| if not self.httpc_params.get("timeout"): | ||
| self.httpc_params["timeout"] = DEFAULT_HTTPC_TIMEOUT |
Member
Author
There was a problem hiding this comment.
instead or copy the same code all around probably it would be better to create a default httpc loader and use it in all the classes
peppelinux
force-pushed
the
peppelinux-patch-1
branch
from
f3febc6 to
6d449b8
Compare
peppelinux
force-pushed
the
peppelinux-patch-1
branch
from
6d449b8 to
d1abf29
Compare
- fixes #93
peppelinux
force-pushed
the
peppelinux-patch-1
branch
from
d1abf29 to
e3a6c43
Compare
jschlyter
approved these changes
Oct 11, 2021
peppelinux
commented
Oct 11, 2021
| kb = issuer.find(url) | ||
| assert len(kb) == 1 | ||
| assert kb[0].httpc_params == {"verify": False} | ||
| assert kb[0].httpc_params == {"timeout": 10, "verify": False} |
Member
Author
There was a problem hiding this comment.
Ops... That would be instead DEFAULT_HTTPC_TIMEOUT ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #93