Skip to content

Add dynamic requested attributes #332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nsklikas wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add dynamic requested attributes #332

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2815bfb
Add dynamic requested attributes
nsklikas Jun 9, 2020
4ea2ba5
Add test
nsklikas Jun 10, 2020
1c11d7e
Replace nested loop with product
nsklikas Jul 6, 2020
d7def47
Fix tests
nsklikas Jul 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Replace nested loop with product
  • Loading branch information
@nsklikas
nsklikas committed Jul 6, 2020
commit 1c11d7e48aa3ca2ebe963e417bee4d8e8d05ee3d
18 changes: 7 additions & 11 deletions src/satosa/backends/saml2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
"""
import copy
import functools
from itertools import product
import json
import logging
import warnings as _warnings
Expand Down Expand Up @@ -250,18 +251,13 @@ def _get_requested_attributes(self, requested_attributes):
attrs = self.converter.from_internal_filter(
self.attribute_profile, requested_attributes
)
requested_attrs = []
for attr in attrs:
# Internal attributes map to the attribute's friendly_name
for req_attr in self.requested_attributes:
if req_attr['friendly_name'] == attr:
requested_attrs.append(
dict(
friendly_name=attr,
required=req_attr['required']
)
)
attrs_req_attrs_product = product(attrs, self.requested_attributes)

requested_attrs = [
dict(friendly_name=attr, required=req_attr['required'])
for (attr, req_attr) in attrs_req_attrs_product
if req_attr['friendly_name'] == attr
]
return requested_attrs

def _get_authn_request_args(
Expand Down