mdd-update-21.0.0#424
Merged
Merged
Conversation
Perfect! The build succeeded. Let me create a summary of what was fixed: Summary I've successfully fixed the Angular 21 build errors. Here are the key changes made: Issues Fixed: NG2010 Error - CUSTOM_ELEMENTS_SCHEMA in components: Removed the schemas property from component decorators in: app.component.ts docs-layout.component.ts These can only be used in NgModules or standalone components, not regular components TS2307 Module Resolution Error: Fixed the "Cannot find module" errors for Angular subpath exports by: Changed moduleResolution from "node" to "bundler" Enabled resolvePackageJsonExports: true Enabled resolvePackageJsonImports: true This allows TypeScript to resolve Angular's new subpath exports like @angular/common/http and @angular/platform-browser/animations Duplicate Configuration: Removed duplicate skipLibCheck: true entry from tsconfig.base.json:11 Configuration Changes: The tsconfig.base.json was updated with: moduleResolution: "bundler" - Allows resolution of subpath exports resolvePackageJsonExports: true - Respects the "exports" field in package.json resolvePackageJsonImports: true - Respects the "imports" field in package.json Result: ✅ Build now completes successfully with only warnings (not errors): JSZip namespace import warning (library issue, not blocking) CommonJS dependency warnings (not blocking) Theme component exclusion warnings (intentional)
mdd-update-angular21
mdd-update
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
mdd-update
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 10 out of 11 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| public title = "Samples"; | ||
| private theme = "default-theme"; | ||
| private styleElem: HTMLStyleElement; | ||
| private styleElem: HTMLStyleElement | undefined; |
There was a problem hiding this comment.
Making styleElem optional will cause a runtime error on line 26 where it's accessed without a null check (this.styleElem.textContent). Either initialize this property in ngOnInit or add null safety checks before accessing it.
Contributor
Author
There was a problem hiding this comment.
@copilot open a new pull request to apply changes based on this feedback
mdd-update
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
4 tasks
Contributor
|
@mddifilippo89 I've opened a new pull request, #425, to work on those changes. Once the pull request is ready, I'll request review from you. |
Co-authored-by: mddifilippo89 <17785923+mddifilippo89@users.noreply.github.com>
…ular-21-and-fixes
HUSSAR-mtrela
approved these changes
Jan 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues Fixed:
NG2010 Error - CUSTOM_ELEMENTS_SCHEMA in components: Removed the schemas property from component decorators in:
app.component.ts
docs-layout.component.ts
These can only be used in NgModules or standalone components, not regular components TS2307 Module Resolution Error: Fixed the "Cannot find module" errors for Angular subpath exports by:
Changed moduleResolution from "node" to "bundler"
Something to consider adding:
Enabled resolvePackageJsonExports: true
Enabled resolvePackageJsonImports: true
This allows TypeScript to resolve Angular's new subpath exports like @angular/common/http and @angular/platform-browser/animations Duplicate Configuration: Removed duplicate skipLibCheck: true entry from tsconfig.base.json:11