fix(grid): strict string typing the grid paging mode #15706
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damyanpetev
reviewed
Apr 14, 2025
| ).toEqual(expectedContent); | ||
| }); | ||
|
|
||
| it('should update GridPagingMode enum from lowerCase to TitleCase', async () => { |
Member
There was a problem hiding this comment.
Assuming these don't work because the resolution is based on the TypeScript LS checking GridPagingMode and verifying it's an igniteui-angular export, the member is based pure string match. Perhaps we have a class declaration or enum filter that fails the check for the new const. Might want to check, even though not really critical for this PR
projects/igniteui-angular/src/lib/grids/columns/column.component.ts
Outdated
Show resolved
Hide resolved
damyanpetev
approved these changes
Apr 16, 2025
Member
damyanpetev
left a comment
damyanpetev
left a comment
There was a problem hiding this comment.
@ChronosSF Also changelog, since it should be noted the input on the grid can now be set in markup directly as 'remote' instead of importing in the enum (requires extra prop/code).
Otherwise, LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.