Conversation
…d of getting from the pyproject
Sahil590
requested review from
AdrianDAlessandro,
alexdewar,
cc-a and
dalonsoa
as code owners
There was a problem hiding this comment.
Pull request overview
This pull request migrates the template repository to an uv-only packaging workflow, removing Poetry and pip-tools support and updating the cookiecutter hook + CI to match.
Changes:
- Add uv project metadata and lockfile for the template repository (
pyproject.toml,uv.lock). - Remove Poetry/pip-tools-specific template files, requirements files, and workflows; update documentation to reflect uv-only support.
- Update the cookiecutter post-generation hook to add dependencies via
uv, and replace related unit tests.
Reviewed changes
Copilot reviewed 17 out of 18 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
uv.lock |
Adds an uv lockfile for reproducible dependency resolution in the template repo. |
pyproject.toml |
Defines the template repo as an uv-managed (non-packaged) project with dev dependency groups. |
README.md |
Updates top-level documentation to uv-only and removes Poetry/pip-tools references. |
hooks/post_gen_project.py |
Switches post-generation dependency setup to uv add and simplifies packaging branching. |
tests/test_pyproject_patching.py |
Replaces prior pyproject patching tests with tests for the new uv hook behaviour. |
cookiecutter.json |
Fixes packaging to "uv" (no longer a multi-option choice). |
dev-requirements.txt |
Removes pip-based dev requirements file from the template repo. |
{{ cookiecutter.project_slug }}/pyproject.toml |
Removes multi-packager templating branches, leaving the uv path. |
{{ cookiecutter.project_slug }}/.github/workflows/ci.yml |
Removes Poetry/pip-tools branches and keeps uv-only CI steps. |
{{ cookiecutter.project_slug }}/.github/workflows/docs.yml |
Removes non-uv branches; docs build uses uv-only installation. |
.github/workflows/ci-uv.yml |
Updates template-repo CI to install deps via uv sync instead of pip requirements. |
.github/workflows/ci-poetry.yml |
Removes Poetry CI workflow. |
.github/workflows/ci-pip-tools.yml |
Removes pip-tools CI workflow. |
{{ cookiecutter.project_slug }}/README.poetry.jinja |
Removes Poetry-specific generated project README fragment. |
{{ cookiecutter.project_slug }}/README.pip-tools.jinja |
Removes pip-tools-specific generated project README fragment. |
{{ cookiecutter.project_slug }}/requirements.txt |
Removes pip-tools autogenerated requirements artefact from the template. |
{{ cookiecutter.project_slug }}/dev-requirements.txt |
Removes pip-tools autogenerated dev requirements artefact from the template. |
{{ cookiecutter.project_slug }}/doc-requirements.txt |
Removes pip-tools autogenerated doc requirements artefact from the template. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+1
to
+3
| from unittest.mock import patch | ||
|
|
||
| from hooks import post_gen_project |
| - name: Create project from template | ||
| # Choose default options | ||
| run: cookiecutter . --no-input packaging=uv rse_team_as_coauthor=true use_bsd3_license=true | ||
| run: uv cookiecutter . --no-input packaging=uv rse_team_as_coauthor=true use_bsd3_license=true |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Comment on lines
7
to
12
| "rse_team_as_coauthor": false, | ||
| "use_bsd3_license": false, | ||
| "packaging": [ | ||
| "poetry", | ||
| "pip-tools", | ||
| "uv" | ||
| ], | ||
| "packaging": "uv", | ||
| "mkdocs": true, | ||
| "add_precommit_workflows": true, | ||
| "automerge_bot_prs": false, |
Comment on lines
+44
to
+48
| def add_uv_dependencies(): | ||
| subprocess.run(["git", "init"], check=True) | ||
| subprocess.run(["uv", "add", "--dev", *DEV_DEPS], check=True) | ||
| if MKDOCS_ENABLED: | ||
| subprocess.run(["uv", "add", "--group", "doc", *DOC_DEPS], check=True) |
dalonsoa
reviewed
May 22, 2026
Contributor
dalonsoa
left a comment
dalonsoa
left a comment
There was a problem hiding this comment.
This looks good to me. I've tested it and it works fine. Just a couple of minor comments.
|
|
||
| - name: Run unit tests | ||
| run: pytest | ||
| run: uv run -m pytest |
Contributor
There was a problem hiding this comment.
Why do you need -m for pytest but not for cookicutter?
| "pip-tools", | ||
| "uv" | ||
| ], | ||
| "packaging": "uv", |
Contributor
There was a problem hiding this comment.
As now there's only one option, we do not need to ask about it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I have removed all the refs to poetry and pip-tools in the template and this repo.
Close #507
Type of change
Key checklist
python -m pytest)pre-commit run --all-files)Further checks
(Indicate issue here: # (issue))