Skip to content

Fix peek method to prevent IndexError #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
InbarAbraham merged 1 commit into from
Jan 16, 2025
Merged

Fix peek method to prevent IndexError #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Update MaxHeap.py 
Updated the `peek` method to check if the heap contains at least one element before accessing `self.heap[1]`. This prevents a potential IndexError when the heap is empty.
  • Loading branch information
@InbarAbraham
InbarAbraham authored Jan 16, 2025
commit 003960a0311e5164318c4c46a1a0a29dea1fe89e
8 changes: 4 additions & 4 deletions MaxHeap.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,10 @@ def push(self, data):
self.__floatUp(len(self.heap) - 1)

def peek(self):
if self.heap[1]:
if len(self.heap)>1:
return self.heap[1]
else:
return False
else:
return false

def pop(self):
if len(self.heap) > 2:
Expand Down Expand Up @@ -57,4 +57,4 @@ def __bubbleDown(self, index):
m = MaxHeap([95, 3, 21])
m.push(10)
print(str(m.heap[0:len(m.heap)]))
print(str(m.pop()))
print(str(m.pop()))