Skip to content

feat(api)!: add carrier delivery estimate; nullable trust grantor fields #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattt merged 1 commit into from
Jul 17, 2026
Merged

feat(api)!: add carrier delivery estimate; nullable trust grantor fields #116

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .stats.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
configured_endpoints: 239
openapi_spec_hash: f0a8620e85b9d96f7ebd57a165897ee4
openapi_spec_hash: f6a1f4bde6efb971145f60df61c0f8cc
config_hash: 1ca082e374ef7000e2a5971e8da740e0
2 changes: 1 addition & 1 deletion scripts/mock
View file
Open in desktop

Large diffs are not rendered by default.

21 changes: 21 additions & 0 deletions src/Increase.Api.Tests/Models/CheckTransfers/CheckTransferListPageResponseTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,9 @@ public void FieldRoundtrip_Works()
[
new()
{
CarrierEstimatedDeliveryAt = DateTimeOffset.Parse(
"2019-12-27T18:11:19.117Z"
),
Category = CheckTransfers::TrackingUpdateCategory.InTransit,
Country = "country",
CreatedAt = DateTimeOffset.Parse("2019-12-27T18:11:19.117Z"),
Expand Down Expand Up @@ -204,6 +207,9 @@ public void FieldRoundtrip_Works()
[
new()
{
CarrierEstimatedDeliveryAt = DateTimeOffset.Parse(
"2019-12-27T18:11:19.117Z"
),
Category = CheckTransfers::TrackingUpdateCategory.InTransit,
Country = "country",
CreatedAt = DateTimeOffset.Parse("2019-12-27T18:11:19.117Z"),
Expand Down Expand Up @@ -332,6 +338,9 @@ public void SerializationRoundtrip_Works()
[
new()
{
CarrierEstimatedDeliveryAt = DateTimeOffset.Parse(
"2019-12-27T18:11:19.117Z"
),
Category = CheckTransfers::TrackingUpdateCategory.InTransit,
Country = "country",
CreatedAt = DateTimeOffset.Parse("2019-12-27T18:11:19.117Z"),
Expand Down Expand Up @@ -463,6 +472,9 @@ public void FieldRoundtripThroughSerialization_Works()
[
new()
{
CarrierEstimatedDeliveryAt = DateTimeOffset.Parse(
"2019-12-27T18:11:19.117Z"
),
Category = CheckTransfers::TrackingUpdateCategory.InTransit,
Country = "country",
CreatedAt = DateTimeOffset.Parse("2019-12-27T18:11:19.117Z"),
Expand Down Expand Up @@ -586,6 +598,9 @@ public void FieldRoundtripThroughSerialization_Works()
[
new()
{
CarrierEstimatedDeliveryAt = DateTimeOffset.Parse(
"2019-12-27T18:11:19.117Z"
),
Category = CheckTransfers::TrackingUpdateCategory.InTransit,
Country = "country",
CreatedAt = DateTimeOffset.Parse("2019-12-27T18:11:19.117Z"),
Expand Down Expand Up @@ -714,6 +729,9 @@ public void Validation_Works()
[
new()
{
CarrierEstimatedDeliveryAt = DateTimeOffset.Parse(
"2019-12-27T18:11:19.117Z"
),
Category = CheckTransfers::TrackingUpdateCategory.InTransit,
Country = "country",
CreatedAt = DateTimeOffset.Parse("2019-12-27T18:11:19.117Z"),
Expand Down Expand Up @@ -838,6 +856,9 @@ public void CopyConstructor_Works()
[
new()
{
CarrierEstimatedDeliveryAt = DateTimeOffset.Parse(
"2019-12-27T18:11:19.117Z"
),
Category = CheckTransfers::TrackingUpdateCategory.InTransit,
Country = "country",
CreatedAt = DateTimeOffset.Parse("2019-12-27T18:11:19.117Z"),
Expand Down
37 changes: 37 additions & 0 deletions src/Increase.Api.Tests/Models/CheckTransfers/CheckTransferTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,9 @@ public void FieldRoundtrip_Works()
[
new()
{
CarrierEstimatedDeliveryAt = DateTimeOffset.Parse(
"2019-12-27T18:11:19.117Z"
),
Category = CheckTransfers::TrackingUpdateCategory.InTransit,
Country = "country",
CreatedAt = DateTimeOffset.Parse("2019-12-27T18:11:19.117Z"),
Expand Down Expand Up @@ -182,6 +185,7 @@ public void FieldRoundtrip_Works()
[
new()
{
CarrierEstimatedDeliveryAt = DateTimeOffset.Parse("2019-12-27T18:11:19.117Z"),
Category = CheckTransfers::TrackingUpdateCategory.InTransit,
Country = "country",
CreatedAt = DateTimeOffset.Parse("2019-12-27T18:11:19.117Z"),
Expand Down Expand Up @@ -317,6 +321,9 @@ public void SerializationRoundtrip_Works()
[
new()
{
CarrierEstimatedDeliveryAt = DateTimeOffset.Parse(
"2019-12-27T18:11:19.117Z"
),
Category = CheckTransfers::TrackingUpdateCategory.InTransit,
Country = "country",
CreatedAt = DateTimeOffset.Parse("2019-12-27T18:11:19.117Z"),
Expand Down Expand Up @@ -434,6 +441,9 @@ public void FieldRoundtripThroughSerialization_Works()
[
new()
{
CarrierEstimatedDeliveryAt = DateTimeOffset.Parse(
"2019-12-27T18:11:19.117Z"
),
Category = CheckTransfers::TrackingUpdateCategory.InTransit,
Country = "country",
CreatedAt = DateTimeOffset.Parse("2019-12-27T18:11:19.117Z"),
Expand Down Expand Up @@ -543,6 +553,7 @@ public void FieldRoundtripThroughSerialization_Works()
[
new()
{
CarrierEstimatedDeliveryAt = DateTimeOffset.Parse("2019-12-27T18:11:19.117Z"),
Category = CheckTransfers::TrackingUpdateCategory.InTransit,
Country = "country",
CreatedAt = DateTimeOffset.Parse("2019-12-27T18:11:19.117Z"),
Expand Down Expand Up @@ -681,6 +692,9 @@ public void Validation_Works()
[
new()
{
CarrierEstimatedDeliveryAt = DateTimeOffset.Parse(
"2019-12-27T18:11:19.117Z"
),
Category = CheckTransfers::TrackingUpdateCategory.InTransit,
Country = "country",
CreatedAt = DateTimeOffset.Parse("2019-12-27T18:11:19.117Z"),
Expand Down Expand Up @@ -792,6 +806,9 @@ public void CopyConstructor_Works()
[
new()
{
CarrierEstimatedDeliveryAt = DateTimeOffset.Parse(
"2019-12-27T18:11:19.117Z"
),
Category = CheckTransfers::TrackingUpdateCategory.InTransit,
Country = "country",
CreatedAt = DateTimeOffset.Parse("2019-12-27T18:11:19.117Z"),
Expand Down Expand Up @@ -1693,6 +1710,7 @@ public void FieldRoundtrip_Works()
[
new()
{
CarrierEstimatedDeliveryAt = DateTimeOffset.Parse("2019-12-27T18:11:19.117Z"),
Category = CheckTransfers::TrackingUpdateCategory.InTransit,
Country = "country",
CreatedAt = DateTimeOffset.Parse("2019-12-27T18:11:19.117Z"),
Expand Down Expand Up @@ -1742,6 +1760,7 @@ public void FieldRoundtrip_Works()
[
new()
{
CarrierEstimatedDeliveryAt = DateTimeOffset.Parse("2019-12-27T18:11:19.117Z"),
Category = CheckTransfers::TrackingUpdateCategory.InTransit,
Country = "country",
CreatedAt = DateTimeOffset.Parse("2019-12-27T18:11:19.117Z"),
Expand Down Expand Up @@ -1810,6 +1829,7 @@ public void SerializationRoundtrip_Works()
[
new()
{
CarrierEstimatedDeliveryAt = DateTimeOffset.Parse("2019-12-27T18:11:19.117Z"),
Category = CheckTransfers::TrackingUpdateCategory.InTransit,
Country = "country",
CreatedAt = DateTimeOffset.Parse("2019-12-27T18:11:19.117Z"),
Expand Down Expand Up @@ -1866,6 +1886,7 @@ public void FieldRoundtripThroughSerialization_Works()
[
new()
{
CarrierEstimatedDeliveryAt = DateTimeOffset.Parse("2019-12-27T18:11:19.117Z"),
Category = CheckTransfers::TrackingUpdateCategory.InTransit,
Country = "country",
CreatedAt = DateTimeOffset.Parse("2019-12-27T18:11:19.117Z"),
Expand Down Expand Up @@ -1922,6 +1943,7 @@ public void FieldRoundtripThroughSerialization_Works()
[
new()
{
CarrierEstimatedDeliveryAt = DateTimeOffset.Parse("2019-12-27T18:11:19.117Z"),
Category = CheckTransfers::TrackingUpdateCategory.InTransit,
Country = "country",
CreatedAt = DateTimeOffset.Parse("2019-12-27T18:11:19.117Z"),
Expand Down Expand Up @@ -1990,6 +2012,7 @@ public void Validation_Works()
[
new()
{
CarrierEstimatedDeliveryAt = DateTimeOffset.Parse("2019-12-27T18:11:19.117Z"),
Category = CheckTransfers::TrackingUpdateCategory.InTransit,
Country = "country",
CreatedAt = DateTimeOffset.Parse("2019-12-27T18:11:19.117Z"),
Expand Down Expand Up @@ -2040,6 +2063,7 @@ public void CopyConstructor_Works()
[
new()
{
CarrierEstimatedDeliveryAt = DateTimeOffset.Parse("2019-12-27T18:11:19.117Z"),
Category = CheckTransfers::TrackingUpdateCategory.InTransit,
Country = "country",
CreatedAt = DateTimeOffset.Parse("2019-12-27T18:11:19.117Z"),
Expand Down Expand Up @@ -2535,18 +2559,23 @@ public void FieldRoundtrip_Works()
{
var model = new CheckTransfers::TrackingUpdate
{
CarrierEstimatedDeliveryAt = DateTimeOffset.Parse("2019-12-27T18:11:19.117Z"),
Category = CheckTransfers::TrackingUpdateCategory.InTransit,
Country = "country",
CreatedAt = DateTimeOffset.Parse("2019-12-27T18:11:19.117Z"),
PostalCode = "postal_code",
};

DateTimeOffset expectedCarrierEstimatedDeliveryAt = DateTimeOffset.Parse(
"2019-12-27T18:11:19.117Z"
);
ApiEnum<string, CheckTransfers::TrackingUpdateCategory> expectedCategory =
CheckTransfers::TrackingUpdateCategory.InTransit;
string expectedCountry = "country";
DateTimeOffset expectedCreatedAt = DateTimeOffset.Parse("2019-12-27T18:11:19.117Z");
string expectedPostalCode = "postal_code";

Assert.Equal(expectedCarrierEstimatedDeliveryAt, model.CarrierEstimatedDeliveryAt);
Assert.Equal(expectedCategory, model.Category);
Assert.Equal(expectedCountry, model.Country);
Assert.Equal(expectedCreatedAt, model.CreatedAt);
Expand All @@ -2558,6 +2587,7 @@ public void SerializationRoundtrip_Works()
{
var model = new CheckTransfers::TrackingUpdate
{
CarrierEstimatedDeliveryAt = DateTimeOffset.Parse("2019-12-27T18:11:19.117Z"),
Category = CheckTransfers::TrackingUpdateCategory.InTransit,
Country = "country",
CreatedAt = DateTimeOffset.Parse("2019-12-27T18:11:19.117Z"),
Expand All @@ -2578,6 +2608,7 @@ public void FieldRoundtripThroughSerialization_Works()
{
var model = new CheckTransfers::TrackingUpdate
{
CarrierEstimatedDeliveryAt = DateTimeOffset.Parse("2019-12-27T18:11:19.117Z"),
Category = CheckTransfers::TrackingUpdateCategory.InTransit,
Country = "country",
CreatedAt = DateTimeOffset.Parse("2019-12-27T18:11:19.117Z"),
Expand All @@ -2591,12 +2622,16 @@ public void FieldRoundtripThroughSerialization_Works()
);
Assert.NotNull(deserialized);

DateTimeOffset expectedCarrierEstimatedDeliveryAt = DateTimeOffset.Parse(
"2019-12-27T18:11:19.117Z"
);
ApiEnum<string, CheckTransfers::TrackingUpdateCategory> expectedCategory =
CheckTransfers::TrackingUpdateCategory.InTransit;
string expectedCountry = "country";
DateTimeOffset expectedCreatedAt = DateTimeOffset.Parse("2019-12-27T18:11:19.117Z");
string expectedPostalCode = "postal_code";

Assert.Equal(expectedCarrierEstimatedDeliveryAt, deserialized.CarrierEstimatedDeliveryAt);
Assert.Equal(expectedCategory, deserialized.Category);
Assert.Equal(expectedCountry, deserialized.Country);
Assert.Equal(expectedCreatedAt, deserialized.CreatedAt);
Expand All @@ -2608,6 +2643,7 @@ public void Validation_Works()
{
var model = new CheckTransfers::TrackingUpdate
{
CarrierEstimatedDeliveryAt = DateTimeOffset.Parse("2019-12-27T18:11:19.117Z"),
Category = CheckTransfers::TrackingUpdateCategory.InTransit,
Country = "country",
CreatedAt = DateTimeOffset.Parse("2019-12-27T18:11:19.117Z"),
Expand All @@ -2622,6 +2658,7 @@ public void CopyConstructor_Works()
{
var model = new CheckTransfers::TrackingUpdate
{
CarrierEstimatedDeliveryAt = DateTimeOffset.Parse("2019-12-27T18:11:19.117Z"),
Category = CheckTransfers::TrackingUpdateCategory.InTransit,
Country = "country",
CreatedAt = DateTimeOffset.Parse("2019-12-27T18:11:19.117Z"),
Expand Down
10 changes: 5 additions & 5 deletions src/Increase.Api/Increase.Api.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,12 @@
<PackageReadmeFile>README.md</PackageReadmeFile>
</PropertyGroup>
<ItemGroup>
<InternalsVisibleTo Include="Increase.Api.Tests"/>
<None Include="..\..\README.md" Pack="true" PackagePath="\"/>
<PackageReference Include="System.Text.Json" Version="9.0.9"/>
<PackageReference Include="Microsoft.SourceLink.GitHub" Version="8.0.0" PrivateAssets="All"/>
<InternalsVisibleTo Include="Increase.Api.Tests" />
<None Include="..\..\README.md" Pack="true" PackagePath="\" />
<PackageReference Include="System.Text.Json" Version="9.0.9" />
<PackageReference Include="Microsoft.SourceLink.GitHub" Version="8.0.0" PrivateAssets="All" />
</ItemGroup>
<ItemGroup Condition="'$(TargetFramework)' == 'netstandard2.0'">
<PackageReference Include="System.Collections.Immutable" Version="8.0.0"/>
<PackageReference Include="System.Collections.Immutable" Version="8.0.0" />
</ItemGroup>
</Project>
17 changes: 17 additions & 0 deletions src/Increase.Api/Models/CheckTransfers/CheckTransfer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1954,6 +1954,22 @@ IReadOnlyDictionary<string, JsonElement> rawData
[JsonConverter(typeof(JsonModelConverter<TrackingUpdate, TrackingUpdateFromRaw>))]
public sealed record class TrackingUpdate : JsonModel
{
/// <summary>
/// The [ISO 8601](https://en.wikipedia.org/wiki/ISO_8601) date and time when
/// the carrier expects the check to be delivered.
/// </summary>
public required System::DateTimeOffset? CarrierEstimatedDeliveryAt
{
get
{
this._rawData.Freeze();
return this._rawData.GetNullableStruct<System::DateTimeOffset>(
"carrier_estimated_delivery_at"
);
}
init { this._rawData.Set("carrier_estimated_delivery_at", value); }
}

/// <summary>
/// The type of tracking event.
/// </summary>
Expand Down Expand Up @@ -2012,6 +2028,7 @@ public required string PostalCode
/// <inheritdoc/>
public override void Validate()
{
_ = this.CarrierEstimatedDeliveryAt;
this.Category.Validate();
_ = this.Country;
_ = this.CreatedAt;
Expand Down
Loading