Skip to content

Balance cluster if node has less slots than expected #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
miguelmdh merged 1 commit into from
Jun 24, 2025
Merged

Balance cluster if node has less slots than expected #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions internal/rediscluster/cluster.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -552,6 +552,8 @@ func (rc *RedisCluster) ResetNode(node *redis.RedisNode) error {
func (rc *RedisCluster) IsBalanced() bool {
masters := rc.GetMasterNodes()
slotsPerMaster := int(math.Ceil(float64(RedisClusterTotalSlots) / float64(len(masters))))
maximumSlots := slotsPerMaster + (slotsPerMaster * RedisNodesUnbalancedThreshold / 100)
minimumSlots := slotsPerMaster - (slotsPerMaster * RedisNodesUnbalancedThreshold / 100)

for _, master := range masters {
masterSlots := master.GetNumberOfSlots()
Expand All @@ -562,10 +564,9 @@ func (rc *RedisCluster) IsBalanced() bool {
return false
}

// Cluster is not balanced if the number of slots is greater than the maximum
maximumSlots := slotsPerMaster + (slotsPerMaster * RedisNodesUnbalancedThreshold / 100)
if masterSlots > maximumSlots {
rc.logger.Info("Cluster needs rebalance: node has more slots than the maximum", "node", master.Name, "slots", masterSlots, "maximumSlots", maximumSlots)
// Cluster is not balanced if the number of slots is not in the expected range
if masterSlots < minimumSlots || masterSlots > maximumSlots {
rc.logger.Info("Cluster needs rebalance: node slots are not in the expected range", "node", master.Name, "slots", masterSlots, "minimumSlots", minimumSlots, "maximumSlots", maximumSlots)
return false
}
}
Expand Down
Loading