fix: pass vendor includes to torch object builds#788
Open
voltjia wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/CMakeLists.txtwhen they are compiled with the system C++ compiler.${MACA_PATH}/includeand Moore${MUSA_ROOT}/includeto the custom torch compile command so InfiniRT vendor runtime headers can resolve their SDK headers.Motivation
Fixes the Moore CI failure observed on PR #785 after #787 updated InfiniRT runtime API usage. The failing compile command for generated torch wrappers included InfiniRT headers but not
/usr/local/musa/include, soinfini/rt/detail/native/cuda/moore/runtime_.hfailed to includemusa_runtime.h.No GitHub issue is linked; this addresses CI failure https://github.com/InfiniTensor/InfiniOps/actions/runs/28645999081/job/84952627941?pr=785.
Type of Change
feat- new feature / new operator / new platformfix- bug fixperf- performance improvement (no behavioral change)refactor- code restructuring without behavior changetest- adding or fixing tests onlydocs- documentation onlybuild/ci- build system or CI configurationchore- tooling, formatting, or other non-code changes!in the Conventional Commits prefix or aBREAKING CHANGE:footer)Platforms Affected
WITH_CPU)WITH_NVIDIA)WITH_ILUVATAR)WITH_METAX)WITH_CAMBRICON)WITH_MOORE)WITH_ASCEND)WITH_TORCH)Smoke Test Result
Moore and MetaX smoke builds require vendor runners/SDKs and were not runnable in this Windows Codex environment. The Moore PR CI is expected to validate the real wheel build path that previously failed.
Test Results on Supported Platforms
musa_runtime.hCI failureFull `pytest` output (optional)
Benchmark / Performance Impact
N/A. This only changes include flags for generated torch object compilation.
Notes for Reviewers
Please focus on the custom system-compiler path under
WITH_METAX OR WITH_MOORE. Normal target include directories do not automatically apply to these custom commands, so vendor SDK include paths need to be passed explicitly alongside InfiniRT and Torch includes.