Skip to content

add allowedSymlinks option#117

Merged
Infinidoge merged 1 commit intoInfinidoge:masterfrom
Misterio77:push-plwvsqorwkzt
Feb 1, 2026
Merged

add allowedSymlinks option#117
Infinidoge merged 1 commit intoInfinidoge:masterfrom
Misterio77:push-plwvsqorwkzt

Conversation

@Misterio77
Copy link
Copy Markdown
Contributor

@Misterio77 Misterio77 commented Dec 26, 2024

Fixes #92.

txt format cherry picked from #103 (thanks @arminius-smh!)

@Misterio77 Misterio77 marked this pull request as ready for review December 27, 2024 04:35
@Misterio77
Copy link
Copy Markdown
Contributor Author

Test case added, and ready to go!

@Misterio77 Misterio77 force-pushed the push-plwvsqorwkzt branch 3 times, most recently from 81bb92f to e8406c7 Compare December 28, 2024 00:56
Copy link
Copy Markdown
Owner

@Infinidoge Infinidoge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nitpick.

Fix that and rebase on master to remove the cherry pick and this should be good to merge.

@Infinidoge
Copy link
Copy Markdown
Owner

Please also rebase on master to remove the cherrypick

@Misterio77 Misterio77 force-pushed the push-plwvsqorwkzt branch 2 times, most recently from 49e527c to b7e46fb Compare May 28, 2025 15:09
@Misterio77
Copy link
Copy Markdown
Contributor Author

Tests passing as expected. Should be ready for your review, @Infinidoge!

@Misterio77 Misterio77 requested a review from Infinidoge May 28, 2025 15:15
Copy link
Copy Markdown
Owner

@Infinidoge Infinidoge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! One small nit, plus the commit should have the right name format (though I can fix this myself when I rebase-merge)

@Infinidoge Infinidoge merged commit ff6604f into Infinidoge:master Feb 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Generate allowed_symlinks.txt when symlinks are used in module

3 participants