Skip to content

use local GOPROXY#322

Merged
InftyAI-Agent merged 1 commit into
InftyAI:mainfrom
pacoxu:go-proxy-registry
Mar 24, 2025
Merged

use local GOPROXY#322
InftyAI-Agent merged 1 commit into
InftyAI:mainfrom
pacoxu:go-proxy-registry

Conversation

@pacoxu
Copy link
Copy Markdown
Contributor

@pacoxu pacoxu commented Mar 21, 2025

What this PR does / why we need it

Which issue(s) this PR fixes

Fixes None

Special notes for your reviewer

For me, I can run like below as I will fail to push to inftyAI and failed for GFW.

export IMAGE_REGISTRY=docker.io/pacoxu
export GOPROXY=https://goproxy.cn
make docker-buildx

Does this PR introduce a user-facing change?

None

@InftyAI-Agent InftyAI-Agent added needs-triage Indicates an issue or PR lacks a label and requires one. needs-priority Indicates a PR lacks a label and requires one. do-not-merge/needs-kind Indicates a PR lacks a label and requires one. labels Mar 21, 2025
@InftyAI-Agent InftyAI-Agent requested a review from kerthcet March 21, 2025 08:29
kerthcet
kerthcet reviewed Mar 21, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@kerthcet kerthcet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only one question.

Comment thread Makefile
@pacoxu pacoxu force-pushed the go-proxy-registry branch from 09cab8f to ac5f0f2 Compare March 21, 2025 08:51
@kerthcet
Copy link
Copy Markdown
Member

kerthcet commented Mar 21, 2025

/lgtm
/approve
/kind cleanup

@InftyAI-Agent InftyAI-Agent added lgtm Looks good to me, indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed do-not-merge/needs-kind Indicates a PR lacks a label and requires one. labels Mar 21, 2025
kerthcet
kerthcet reviewed Mar 21, 2025
View reviewed changes
Comment thread Makefile Outdated
@pacoxu pacoxu force-pushed the go-proxy-registry branch from ac5f0f2 to 2a3a2d1 Compare March 21, 2025 20:10
@InftyAI-Agent InftyAI-Agent removed the lgtm Looks good to me, indicates that a PR is ready to be merged. label Mar 21, 2025
@pacoxu pacoxu changed the title use local GOPROXY; support IMAGE_REGISTRY to override local build image use local GOPROXY Mar 21, 2025
@kerthcet
Copy link
Copy Markdown
Member

kerthcet commented Mar 24, 2025

/lgtm
/approve
Thanks @pacoxu

@InftyAI-Agent InftyAI-Agent added the lgtm Looks good to me, indicates that a PR is ready to be merged. label Mar 24, 2025
@InftyAI-Agent InftyAI-Agent merged commit 6a28e80 into InftyAI:main Mar 24, 2025
nayihz
nayihz reviewed Mar 26, 2025
View reviewed changes
Comment thread Makefile
PLATFORMS ?= linux/arm64,linux/amd64,linux/s390x,linux/ppc64le
.PHONY: docker-buildx
docker-buildx: ## Build and push docker image for the manager for cross-platform support
export GOPROXY=$(GOPROXY)
Copy link
Copy Markdown
Contributor

@nayihz nayihz Mar 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better not to export GOPROXY If GOPROXY=""

Copy link
Copy Markdown
Contributor Author

@pacoxu pacoxu Mar 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I opened #330 to fix this. Is that better?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kerthcet kerthcet kerthcet left review comments

+1 more reviewer

@nayihz nayihz nayihz left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@kerthcet kerthcet

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Looks good to me, indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a label and requires one. needs-triage Indicates an issue or PR lacks a label and requires one.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pacoxu @kerthcet @nayihz @InftyAI-Agent