[feature/#2] db 수정, entity 수정, jpa 레파지토리 구현 #7
Merged
Conversation
Member
Author
|
test db : board/major_info/user 만들면 됨. |
Dong-Hyeon-Yu
force-pushed
the
feature/#2
branch
from
b21964e to
c8a90bc
Compare
Mingyum-Kim
reviewed
Dec 29, 2021
Mingyum-Kim
left a comment
Mingyum-Kim
left a comment
Contributor
There was a problem hiding this comment.
Test 코드 잘 돌아가는 거 확인했습니다!
| public Board board(@RequestParam Integer id) { | ||
| return repository.findById(id); | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
하단에 findByType에서 오류 떠서 findAllByCategory로 수정했습니다!
Contributor
There was a problem hiding this comment.
아 수정 되어있네용,, 이전 PR이랑 헷갈렸습니다 ㅎㅎ
- MemberEntity, IbasInformation : joined 가입시간 자동 적용되게 수정 - MemberServiceTest : 멤버 엔티티 변경에 따른 테스트 코드 리팩토링
+) MemberServiceTest:update 리팩토링
Dong-Hyeon-Yu
force-pushed
the
feature/#2
branch
from
c8a90bc to
9b9bafe
Compare
Member
Author
|
api/board/all 안되는거 BoardController 수정해서 rebase 했습니다~ 확인해주세용 |
외부에서 엔티티 변경 시도 차단. 생성자 이용하도록.
외부에서 엔티티 변경 시도 차단. 생성자 이용하도록.
Mingyum-Kim
approved these changes
Dec 30, 2021
Mingyum-Kim
left a comment
Mingyum-Kim
left a comment
Contributor
There was a problem hiding this comment.
Approve 안 누른거 이제 알았네요 😢
Test코드랑 Application 잘 돌아가는 거 확인했습니다
…lse </code> 적용할 것. Eager Fetch 는 연관관계 해당하는 모든 데이터를 연쇄적으로 fetch 할 수 있음. fk 가 null 값이 없다면 optional = false 꼭 설정, (Column(nullable=false) 로 지정해도 됨) 그래야 jpa가 sql 생성할 때 outer join 이 아닌 inner join 으로 생성.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.