Many Changes#2
Open
johnseekins wants to merge 17 commits into
Open
Conversation
added 17 commits
April 25, 2022 10:06
… the make file Signed-off-by: John Seekins <john@civiceagle.com>
Signed-off-by: John Seekins <john@civiceagle.com>
Signed-off-by: John Seekins <john@civiceagle.com>
Signed-off-by: John Seekins <john@civiceagle.com>
Signed-off-by: John Seekins <john@civiceagle.com>
Signed-off-by: John Seekins <john@civiceagle.com>
…. and actually tag things) Signed-off-by: John Seekins <john@civiceagle.com>
Signed-off-by: John Seekins <john@civiceagle.com>
Signed-off-by: John Seekins <john@civiceagle.com>
Signed-off-by: John Seekins <john@civiceagle.com>
Signed-off-by: John Seekins <john@civiceagle.com>
Signed-off-by: John Seekins <john@civiceagle.com>
Signed-off-by: John Seekins <john@civiceagle.com>
Signed-off-by: John Seekins <john@civiceagle.com>
Signed-off-by: John Seekins <john@civiceagle.com>
Signed-off-by: John Seekins <john@civiceagle.com>
Signed-off-by: John Seekins <john@civiceagle.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So probably the biggest changes are around the build process itself. I've improved the Makefile to properly track vendor files, run tests/linting/etc. and even build/push docker containers. In the process, we now build against Go 1.17 (waiting on golang-lint support for Go 1.18).
Beyond that, I switched the statsd client to the gometric statsd client (which has more recent commits and generally looks healthier), added JSON logging with logrus, and updated the README quite a bit.
There's still a few tweaks to make (mostly around hard-coded names in the Makefile...should be fairly easy to fix, but...