Conversation
|
@PaulHax It looks like I can't add you directly as a reviewer, but I'd appreciate if you could check over this one briefly |
|
LGTM. Verifying https support for the rewritten links would be ideal, but realistically everyone should be on https. The one link I did test 404-ed (a bibliography link), but that's because of the page and not the https link. |
|
Thanks @floryst . I agree that ideally we would test each link individually, but as I am applying these updates to all ITK remote modules I don't have the manpower to go through each one. I'm relying primarily on CI to make sure nothing breaks in each build, if you or others find broken links in documentation it would be good to correct those in a subsequent fixup. |
|
Sure thing; I would much rather you not validate the links anyhow. :) I did a sanity check to ensure that code-related URLs are okay. The majority are non-code rewrites; those links are more tolerant to breakage. |
|
LGTM! |
|
🎉 This PR is included in version 1.0.0-b.15 🎉 The release is available on: Your semantic-release bot 📦🚀 |
4 participants
Automated reformatting with https://github.com/InsightSoftwareConsortium/ITK/blob/master/Utilities/Maintenance/ApplyScriptToRemotes.sh