Uninitialized member variables

[jhlegarreta]

Description

Several classes have uninitialized member variables.

Steps to Reproduce

Run the tests, and check the output to the standard output:

• itk::BSplineScatteredDataPointSetToImageFilter: Uninitialized members in class:
  itk::BSplineScatteredDataPointSetToImageFilter::m_OmegaLatticePerThread
itk::BSplineScatteredDataPointSetToImageFilter::m_DeltaLatticePerThread
  https://open.cdash.org/testDetails.php?test=736332599&build=5770289

• itk::ThresholdLabelerImageFilter: Uninitialized members in class:
  itk::ThresholdLabelerImageFilter::m_Thresholds
itk::ThresholdLabelerImageFilter::m_RealThresholds
  https://open.cdash.org/testDetails.php?test=736333475&build=5770289

Expected behavior

All member variables must have an initial/default value using the convention adopted in ITK.

Actual behavior

Members do not have any assigned value when being printed in tests.

Reproducibility

100%.

Versions

Current master branch.

Environment

Independent of the environment.

[dzenanz]

Is this issue still valid? @andinet tried and failed to reproduce on Windows - Visual Studio.

[jhlegarreta]

Having a look at the current test outputs I'd dare to say they still are:
https://open.cdash.org/testDetails.php?test=753066184&build=5857204

  Omega lattice per thread: ()
  Delta lattice per thread: ()

Having a look at the class, the members are not initialized either in their declaration or in the constructor.

And
https://open.cdash.org/testDetails.php?test=753066916&build=5857204

  Thresholds: ()
  Real Thresholds: ()

With the same conclusion.

[dzenanz]

What should they be initialized to? User is required to set the thresholds he wants the labels for. I guess it is similar for the other class too.

[jhlegarreta]

I guess there is no right/wrong answer for what they "should be initialized" to. As for the m_DeltaLatticePerThread and m_OmegaLatticePerThread they are initialized later in the code. If threads come into play, defaulting them to 1 is my best guess. I ignore if there is a default number of work units...

As for the itk::ThresholdLabelerImageFilter, m_Thresholdsand m_RealThresholds are cleared in the constructor, so if that is correct, defaulting them to some value does indeed make no sense.

[hjmjohnson]

Much work has been done to address this by @N-Dekker; we have no known open items.