STYLE: Replace new by C++14 std::make_unique#2574
Merged
N-Dekker merged 1 commit intoInsightSoftwareConsortium:masterfrom Jun 4, 2021
Merged
STYLE: Replace new by C++14 std::make_unique#2574N-Dekker merged 1 commit intoInsightSoftwareConsortium:masterfrom
new by C++14 std::make_unique#2574N-Dekker merged 1 commit intoInsightSoftwareConsortium:masterfrom
Conversation
According to Clang-Tidy `modernize-make-unique`: https://clang.llvm.org/extra/clang-tidy/checks/modernize-make-unique.html C++ Core Guidelines, March 11, 2021, R.23: Use make_unique() to make unique_ptrs http://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Rr-make_unique
github-actions
bot
added
area:Core
dzenanz
approved these changes
Jun 4, 2021
Contributor
Author
|
Honestly, even though I mentioned Clang-Tidy |
Contributor
Author
|
itkPyBufferMemoryLeakTest keeps failing, on ITK.macOS.Python (Azure.Mac-1622805395877): https://open.cdash.org/viewTest.php?onlyfailed&buildid=7266522 That's unrelated to the C++14 upgrade, right? |
Member
|
@N-Dekker I hope so. It's failing on all the PR's recently clogging up the system. |
N-Dekker
added a commit
to SuperElastix/elastix
that referenced
this pull request
Aug 26, 2021
According to Clang-Tidy modernize-make-unique: https://clang.llvm.org/extra/clang-tidy/checks/modernize-make-unique.html C++ Core Guidelines, August 19, 2021, R.23: Use make_unique() to make unique_ptrs http://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Rr-make_unique Following ITK pull request InsightSoftwareConsortium/ITK#2574 commit InsightSoftwareConsortium/ITK@22bce72 (4 June 2021)
N-Dekker
added a commit
to SuperElastix/elastix
that referenced
this pull request
Aug 26, 2021
According to Clang-Tidy modernize-make-unique: https://clang.llvm.org/extra/clang-tidy/checks/modernize-make-unique.html C++ Core Guidelines, August 19, 2021, R.23: Use make_unique() to make unique_ptrs http://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Rr-make_unique Following ITK pull request InsightSoftwareConsortium/ITK#2574 commit InsightSoftwareConsortium/ITK@22bce72 (4 June 2021)
N-Dekker
added a commit
to SuperElastix/elastix
that referenced
this pull request
Aug 26, 2021
According to Clang-Tidy modernize-make-unique: https://clang.llvm.org/extra/clang-tidy/checks/modernize-make-unique.html C++ Core Guidelines, August 19, 2021, R.23: Use make_unique() to make unique_ptrs http://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Rr-make_unique Following ITK pull request InsightSoftwareConsortium/ITK#2574 commit InsightSoftwareConsortium/ITK@22bce72 (4 June 2021)
N-Dekker
added a commit
to SuperElastix/elastix
that referenced
this pull request
Aug 27, 2021
According to Clang-Tidy modernize-make-unique: https://clang.llvm.org/extra/clang-tidy/checks/modernize-make-unique.html C++ Core Guidelines, August 19, 2021, R.23: Use make_unique() to make unique_ptrs http://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Rr-make_unique Following ITK pull request InsightSoftwareConsortium/ITK#2574 commit InsightSoftwareConsortium/ITK@22bce72 (4 June 2021)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to Clang-Tidy
modernize-make-unique:https://clang.llvm.org/extra/clang-tidy/checks/modernize-make-unique.html
C++ Core Guidelines, March 11, 2021, R.23: Use make_unique() to make unique_ptrs
http://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Rr-make_unique