ENH: Declare RGBPixel, RGBAPixel constructors from component explicit#3238
Merged
hjmjohnson merged 1 commit intoMar 1, 2022
Merged
Conversation
Prevents implicit conversion of a component value to `RGBPixel` or `RGBAPixel`. Aims to avoid possible flaws, like the one addressed by: Pull request InsightSoftwareConsortium#3223 commit 490ef8c "BUG: Fix `ColorTableTestSpecialConditionChecker` component/pixel mix-up" Added _deleted_ `RGBPixel(nullptr_t)` and `RGBAPixel(nullptr_t)` constructors, especially to avoid erroneous user code like `RGBPixel pixel = 0`.
github-actions
Bot
added
area:Core
dzenanz
approved these changes
Feb 28, 2022
Contributor
Author
|
/azp run ITK.Linux |
hjmjohnson
approved these changes
Mar 1, 2022
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevents implicit conversion of a component value to
RGBPixelorRGBAPixel. Aims to avoid possible flaws, like the one addressed by:Pull request #3223
commit 490ef8c
"BUG: Fix
ColorTableTestSpecialConditionCheckercomponent/pixel mix-up"Added deleted
RGBPixel(nullptr_t)andRGBAPixel(nullptr_t)constructors, especially to avoid erroneous user code like
RGBPixel pixel = 0.