Skip to content

BUG: Re-add coverage for itk::RegistrationParameterScales types#3406

Merged
tbirdso merged 1 commit into
InsightSoftwareConsortium:masterfrom
tbirdso:metricv4-wrapping-coverage
May 3, 2022
Merged

BUG: Re-add coverage for itk::RegistrationParameterScales types#3406
tbirdso merged 1 commit into
InsightSoftwareConsortium:masterfrom
tbirdso:metricv4-wrapping-coverage

Conversation

@tbirdso
Copy link
Copy Markdown
Contributor

@tbirdso tbirdso commented May 2, 2022

Resolves InsightSoftwareConsortium/ITKSphinxExamples#349 in ITKSphinxExamples where itk.RegistrationParameterScalesFromPhysicalShift is wrapped only for itk.JensenHavrdaChandraTsallisPointSetToPointSetMetricv4 inputs that are templated over itk.PointSet[itk.SS,2].

Fixes template wrappings such that scales classes are templated over pointset-to-pointset metrics including real types (itk.F) and more than two dimensions if configured. Previously only the first template list entry was being parsed by the _add_pointset_types macro.

PR Checklist

Refer to the ITK Software Guide for
further development details if necessary.

@tbirdso tbirdso requested a review from brad-t-moore May 2, 2022 21:00
@github-actions github-actions Bot added area:Python wrapping Python bindings for a class area:Registration Issues affecting the Registration module type:Bug Inconsistencies or issues which will cause an incorrect result under some or all circumstances type:Coverage Code coverage impacts labels May 2, 2022
Comment thread Modules/Registration/Metricsv4/wrapping/itkMetricv4Types.wrap
Comment thread Modules/Registration/Metricsv4/wrapping/itkMetricv4Types.wrap
Copy link
Copy Markdown
Contributor

@brad-t-moore brad-t-moore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as the dashboard is green this looks good to me.

@tbirdso
Copy link
Copy Markdown
Contributor Author

tbirdso commented May 3, 2022

Dashboard is green 🟢 Merging.

@tbirdso tbirdso merged commit 77ea6d4 into InsightSoftwareConsortium:master May 3, 2022
hjmjohnson pushed a commit to hjmjohnson/ITK that referenced this pull request May 6, 2026
…v4-wrapping-coverage

BUG: Re-add coverage for `itk::RegistrationParameterScales` types
hjmjohnson pushed a commit to hjmjohnson/ITK that referenced this pull request May 12, 2026
…v4-wrapping-coverage

BUG: Re-add coverage for `itk::RegistrationParameterScales` types
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:Python wrapping Python bindings for a class area:Registration Issues affecting the Registration module type:Bug Inconsistencies or issues which will cause an incorrect result under some or all circumstances type:Coverage Code coverage impacts

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CTest Failures

2 participants