Skip to content

COMP: Exclude README, Utilities/Maintenance and other files from AZP CI#3930

Merged
dzenanz merged 2 commits intoInsightSoftwareConsortium:masterfrom
N-Dekker:Exclude-README.md-from-AzurePipelines-trigger
Feb 23, 2023
Merged

COMP: Exclude README, Utilities/Maintenance and other files from AZP CI#3930
dzenanz merged 2 commits intoInsightSoftwareConsortium:masterfrom
N-Dekker:Exclude-README.md-from-AzurePipelines-trigger

Conversation

@N-Dekker
Copy link
Copy Markdown
Contributor

Excluded various files and directories from triggering a CI run, according to Azure Pipelines "trigger definition" at https://learn.microsoft.com/en-us/azure/devops/pipelines/yaml-schema/trigger?view=azure-pipelines#trigger-batch-branches-paths-tags

These are files that are not tested by the CI anyway.

This pull request aims to avoid running the virtual machines of the CI unnecessarily, to save energy and to reduce the time waiting for the CI.

@github-actions github-actions bot added type:Compiler Compiler support or related warnings type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots type:Testing Ensure that the purpose of a class is met/the results on a wide set of test cases are correct labels Feb 17, 2023
@N-Dekker
Copy link
Copy Markdown
Contributor Author

Looks like it does not work 😢 Maybe I should have used pr (as well as trigger): https://learn.microsoft.com/en-us/azure/devops/pipelines/yaml-schema/pr?view=azure-pipelines#pr-autocancel-branches-paths-drafts

@dzenanz
Copy link
Copy Markdown
Member

dzenanz commented Feb 18, 2023

Maybe this needs to be in master before it has an effect?

@N-Dekker
Copy link
Copy Markdown
Contributor Author

Maybe this needs to be in master before it has an effect?

Maybe, but I'm not sure. Usually I think the yml file of a branch does affect the CI build of that particular branch. I'll still try to tweak the yml files a little bit more.

@N-Dekker N-Dekker force-pushed the Exclude-README.md-from-AzurePipelines-trigger branch 3 times, most recently from fb72cd9 to a458b97 Compare February 18, 2023 16:35
@N-Dekker
Copy link
Copy Markdown
Contributor Author

N-Dekker commented Feb 18, 2023

Is it possible to share one and the same list of excluded files between all (six) AzurePipelines*.yml files? Current list of excluded files:

- CODE_OF_CONDUCT.md
- CONTRIBUTING.md
- GettingStarted.md
- GOVERNANCE.md
- LICENSE
- NOTICE
- README.md
- Documentation/*
- Utilities/Maintenance/*

I would have liked "*.md", but that does not seem to be accepted by AZP.

ITK appears to have a separate AzurePipelines*.yml file for each supported platform.

@N-Dekker N-Dekker force-pushed the Exclude-README.md-from-AzurePipelines-trigger branch from a458b97 to 8dd55b2 Compare February 18, 2023 17:24
Excluded various files which are not tested by the CI anyway from triggering a
CI run.
@N-Dekker N-Dekker force-pushed the Exclude-README.md-from-AzurePipelines-trigger branch from 8dd55b2 to a10a8df Compare February 18, 2023 17:27
@N-Dekker N-Dekker marked this pull request as ready for review February 18, 2023 22:01
@N-Dekker
Copy link
Copy Markdown
Contributor Author

OK, I think this should work, but I have no evidence that it does 🤷

@N-Dekker
Copy link
Copy Markdown
Contributor Author

For the record, you may also suppress the CI by adding the string [skip ci] to your commit message. However, if you do so in a pull request:

You won't be able to merge the pull request if your repository is configured to require specific checks to pass first. To allow the pull request to be merged you can push a new commit to the pull request without the skip instruction in the commit message.

Source: https://docs.github.com/en/actions/managing-workflow-runs/skipping-workflow-runs

@dzenanz dzenanz merged commit 4728e7c into InsightSoftwareConsortium:master Feb 23, 2023
@dzenanz
Copy link
Copy Markdown
Member

dzenanz commented Feb 23, 2023

Maybe we can test whether this works by creating a new PR with that maintenance script you used recently?

N-Dekker added a commit to SuperElastix/elastix that referenced this pull request Feb 27, 2023
Further extended the exclusion of specific files from the Azure Pipelines CI runs. Those files were not tested by the CI anyway.

Inspired by ITK pull request InsightSoftwareConsortium/ITK#3930 commit InsightSoftwareConsortium/ITK@eb5ca25 "COMP: Exclude Utilities/Maintenance and documentation files from AZP CI"
N-Dekker added a commit to SuperElastix/elastix that referenced this pull request Feb 27, 2023
Further extended the exclusion of specific files from the Azure Pipelines CI runs. Those files were not tested by the CI anyway.

Inspired by ITK pull request InsightSoftwareConsortium/ITK#3930 commit InsightSoftwareConsortium/ITK@eb5ca25 "COMP: Exclude Utilities/Maintenance and documentation files from AZP CI"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:Compiler Compiler support or related warnings type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots type:Testing Ensure that the purpose of a class is met/the results on a wide set of test cases are correct

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants