STYLE: Add in-class {} member initializers having trailing comments#3945
Merged
hjmjohnson merged 1 commit intoInsightSoftwareConsortium:masterfrom Mar 7, 2023
Conversation
github-actions
bot
added
type:Testing
Previous commits that added `{}` initializers to data members by means of
regular expressions had overlooked member declarations that had a trailing
comment.
Follow-up to pull request InsightSoftwareConsortium#3851
commit 5e2c49f
"STYLE: Add in-class `{}` member initializers to objects created by New()"
N-Dekker
force-pushed
the
Add-member-initializers-having-trailing-comment
branch
from
46aa921 to
df57675
Compare
github-actions
bot
added
the
area:Segmentation
N-Dekker
added a commit
to N-Dekker/ITK
that referenced
this pull request
Mar 4, 2023
The script that was used for the following pull requests: pull request InsightSoftwareConsortium#3851 "STYLE: Add in-class `{}` member initializers to objects created by New()" pull request InsightSoftwareConsortium#3913 "STYLE: Add in-class `{}` initializers to classes with virtual functions" pull request InsightSoftwareConsortium#3917 "STYLE: Add in-class `{}` initializers to classes with override = default" pull request InsightSoftwareConsortium#3941 "STYLE: Add in-class `{}` member initializers to 3-letter data members" pull request InsightSoftwareConsortium#3945 "STYLE: Add in-class `{}` member initializers having trailing comments"
dzenanz
approved these changes
Mar 4, 2023
N-Dekker
added a commit
to N-Dekker/ITK
that referenced
this pull request
Mar 6, 2023
The script that was used for the following pull requests: pull request InsightSoftwareConsortium#3851 "STYLE: Add in-class `{}` member initializers to objects created by New()" pull request InsightSoftwareConsortium#3913 "STYLE: Add in-class `{}` initializers to classes with virtual functions" pull request InsightSoftwareConsortium#3917 "STYLE: Add in-class `{}` initializers to classes with override = default" pull request InsightSoftwareConsortium#3941 "STYLE: Add in-class `{}` member initializers to 3-letter data members" pull request InsightSoftwareConsortium#3945 "STYLE: Add in-class `{}` member initializers having trailing comments"
hjmjohnson
approved these changes
Mar 7, 2023
dzenanz
pushed a commit
that referenced
this pull request
Mar 20, 2023
The script that was used for the following pull requests: pull request #3851 "STYLE: Add in-class `{}` member initializers to objects created by New()" pull request #3913 "STYLE: Add in-class `{}` initializers to classes with virtual functions" pull request #3917 "STYLE: Add in-class `{}` initializers to classes with override = default" pull request #3941 "STYLE: Add in-class `{}` member initializers to 3-letter data members" pull request #3945 "STYLE: Add in-class `{}` member initializers having trailing comments"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous commits that added
{}initializers to data members by means of regular expressions had overlooked member declarations that had a trailing comment.Follow-up to pull request #3851 commit 5e2c49f
"STYLE: Add in-class
{}member initializers to objects created by New()"