COMP: Place #define _SILENCE_..._DEPRECATION_WARNING before #include

[N-Dekker]

Moved each _SILENCE_NONFLOATING_COMPLEX_DEPRECATION_WARNING macro definition upward, placing it before the very first #include statement.

Fixes Visual C++ 2022 warnings like:

warning C4996: 'std::complex::complex': warning STL4037: The effect of instantiating the template std::complex for any type other than float, double, or long double is unspecified. You can define _SILENCE_NONFLOATING_COMPLEX_DEPRECATION_WARNING to suppress this warning.

Follow-up to pull request #3897 commit 3a9c762
"COMP: Supress warning in MSVC for non-float complex"

(Cherry-picked from pull request #3969.)

[blowekamp]

Thanks

[N-Dekker]

Thanks

You're welcome @blowekamp Just wondering, did your original PR #3897 commit 3a9c762 already suppress the warnings for you? Because at my side, I kept seeing those warnings.

[N-Dekker]

For the record, here a minimal example (https://godbolt.org/z/Ks51f1bjo):

#include <complex>
// Doing the #define after the #include has no effect!
#define _SILENCE_NONFLOATING_COMPLEX_DEPRECATION_WARNING
std::complex<int> myComplex;

Using command-line options /W3 /std:c++17 /Bv, it has the following output:

<source>(8): warning C4996: 'std::complex<int>::complex': warning STL4037: The effect of instantiating the template std::complex for any type other than float, double, or long double is unspecified. You can define _SILENCE_NONFLOATING_COMPLEX_DEPRECATION_WARNING to suppress this warning.
Compiler Passes:
C:\data\msvc\14.34.31931-Pre\bin\Hostx64\arm64\cl.exe: Version 19.34.31931.0

Place the #define before the #include to suppress the warning. 😃

[N-Dekker]

I just realized that the warning is not specific to C++17, it also appears when compiling with /std:c++14. The warning appears to be added to MSVC very recently.

[N-Dekker]

Shall I still do an amend/force-push to adjust the comment a little bit? It has a minor typo ("Supress"). No problem, of course.

[dzenanz]

Yes, please fix the misspelling.