STYLE: Remove std::allocator from TestImportImageContainer (Common/test)#3971
Merged
dzenanz merged 1 commit intoInsightSoftwareConsortium:masterfrom Mar 21, 2023
Conversation
Replaced the use of `std::allocator` by the equivalent `new Element[]` and `delete[]` statements. Renamed `m_MemoryAllocatedByAllocator` to `m_MemoryAllocatedByTestImportImageContainer`. Aims to simplify the code, and make it easier to upgrade to C++17 and further. C++17 has deprecated the `std::allocator::allocate` and `std::allocator::destroy` function calls that are removed with this commit.
dzenanz
approved these changes
Mar 21, 2023
Contributor
Author
|
I think this PR is ready, but Label PRs / build (pull_request_target) has failed, saying:
Do you have a clue? |
Member
|
I assume that some dependency in that GitHub action has broken again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced the use of
std::allocatorby the equivalentnew Element[]anddelete[]statements. Renamedm_MemoryAllocatedByAllocatortom_MemoryAllocatedByTestImportImageContainer.Aims to simplify the code, and make it easier to upgrade to C++17 and further. C++17 has deprecated the
std::allocator::allocateandstd::allocator::destroyfunction calls that are removed with this commit.Aims to supersede commit "COMP: Replace std::allocator member function calls deprecated in C++17" from pull request #3969
For the record,
std::allocatorwas added to TestImportImageContainer with commit 1a3d16d, by Tom Vercauteren (@tvercaut), April 2, 2009.