STYLE: Replace T var = NumericTraits<T>::ZeroValue() having whitespace#4015
Merged
hjmjohnson merged 1 commit intoInsightSoftwareConsortium:masterfrom Apr 18, 2023
Conversation
Replaced initialization by `NumericTraits<T>::ZeroValue()` with empty `{}`
initializers. Did so by Replace in Files, using regular expressions:
Find what: (.+)([ ]+\w+) = NumericTraits<\1>::ZeroValue\(\);
Find what: (.+)([ ]+\w+) = itk::NumericTraits<\1>::ZeroValue\(\);
Find what: (.+)([ ]+\w+) =\r\n[ ]+NumericTraits<\1>::ZeroValue\(\);
Find what: (.+)([ ]+\w+) =\r\n[ ]+itk::NumericTraits<\1>::ZeroValue\(\);
Replace with: $1$2{};
Follow-up to pull request InsightSoftwareConsortium#3958
commit 42b0bfc
"STYLE: Replace `T var = NumericTraits<T>::ZeroValue()` with `T var{}`" (which
did not yet address initializations of which the specification of `T` has one or
more spaces inside, and initializations that took multiple lines of code.)
github-actions
bot
added
type:Testing
hjmjohnson
approved these changes
Apr 17, 2023
Member
hjmjohnson
left a comment
hjmjohnson
left a comment
There was a problem hiding this comment.
Thank you for your tenacity in tracking these down.
dzenanz
approved these changes
Apr 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced initialization by
NumericTraits<T>::ZeroValue()with empty{}initializers. Did so by Replace in Files, using regular expressions:Follow-up to pull request #3958 commit 42b0bfc "STYLE: Replace
T var = NumericTraits<T>::ZeroValue()withT var{}" (which did not yet address initializations of which the specification ofThas one or more spaces inside, and initializations that took multiple lines of code.)