ENH: Consistency in wrapped mesh types#403
Merged
thewtex merged 1 commit intoJan 13, 2019
Merged
Conversation
This patch simplifies, uses consistently, and expand pixel types supported for mesh processing with Python wrapping. We now do not explicitly specify the mesh traits used. The itk::DefaultStaticMeshTraits with default template parameters are used. This serves all current use cases. The use of the default traits greatly improves the Python user experience and makes it easier to wrap additional classes. More pixel types for the PointSet point and Mesh cells are wrapped -- all enabled wrapping scalar pixel types verses just the real types. These types are used consistently across the wrapped classes.
thewtex
requested review from
bpaniagua,
dzenanz,
fbudin69500,
jhlegarreta and
phcerdan
dzenanz
approved these changes
Jan 12, 2019
Member
dzenanz
left a comment
dzenanz
left a comment
There was a problem hiding this comment.
Will this help InsightSoftwareConsortium/ITKSphinxExamples#66 roll forward?
phcerdan
approved these changes
Jan 12, 2019
Member
Author
Yes :-D |
hjmjohnson
pushed a commit
to hjmjohnson/ITK
that referenced
this pull request
May 6, 2026
…-mesh-pixel-types ENH: Consistency in wrapped mesh types
hjmjohnson
pushed a commit
to hjmjohnson/ITK
that referenced
this pull request
May 12, 2026
…-mesh-pixel-types ENH: Consistency in wrapped mesh types
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch simplifies, uses consistently, and expand pixel types
supported for mesh processing with Python wrapping.
We now do not explicitly specify the mesh traits used. The
itk::DefaultStaticMeshTraits with default template parameters are used.
This serves all current use cases. The use of the default traits greatly
improves the Python user experience and makes it easier to wrap
additional classes.
More pixel types for the PointSet point and Mesh cells are wrapped --
all enabled wrapping scalar pixel types verses just the real types.
These types are used consistently across the wrapped classes.