Skip to content

DOC: Add GetNameOfClass macro's to DOXYGEN_PREDEFINED#4498

Merged
dzenanz merged 1 commit into
InsightSoftwareConsortium:masterfrom
N-Dekker:Add-GetNameOfClass-to-DOXYGEN_PREDEFINED
Mar 7, 2024
Merged

DOC: Add GetNameOfClass macro's to DOXYGEN_PREDEFINED#4498
dzenanz merged 1 commit into
InsightSoftwareConsortium:masterfrom
N-Dekker:Add-GetNameOfClass-to-DOXYGEN_PREDEFINED

Conversation

@N-Dekker
Copy link
Copy Markdown
Contributor

@N-Dekker N-Dekker commented Mar 7, 2024

Currently, the itkVirtualGetNameOfClassMacro and itkOverrideGetNameOfClassMacro calls do not get expanded properly by Doxygen. This commit aims to fix the output from Doxygen at https://itk.org/Doxygen/html/

Currently, the itkVirtualGetNameOfClassMacro and itkOverrideGetNameOfClassMacro
calls do not get expanded properly by Doxygen. This commit aims to fix the
output from Doxygen at https://itk.org/Doxygen/html/
@github-actions github-actions Bot added type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots type:Documentation Documentation improvement or change area:Documentation Issues affecting the Documentation module labels Mar 7, 2024
@N-Dekker N-Dekker marked this pull request as ready for review March 7, 2024 17:19
Copy link
Copy Markdown
Member

@dzenanz dzenanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code change looks good, so the only question is: does it work?

@N-Dekker
Copy link
Copy Markdown
Contributor Author

N-Dekker commented Mar 7, 2024

Code change looks good, so the only question is: does it work?

I hope so 😺 Did not test it locally, but I think it's OK. Otherwise, at least it wouldn't harm, I guess.

@blowekamp blowekamp self-requested a review March 7, 2024 20:13
Copy link
Copy Markdown
Member

@blowekamp blowekamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dzenanz dzenanz merged commit 77f5c6d into InsightSoftwareConsortium:master Mar 7, 2024
@N-Dekker N-Dekker deleted the Add-GetNameOfClass-to-DOXYGEN_PREDEFINED branch March 13, 2024 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:Documentation Issues affecting the Documentation module type:Documentation Documentation improvement or change type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants