STYLE: Remove unused "one-filled" direction matrices from tests#4903
Merged
dzenanz merged 1 commit intoInsightSoftwareConsortium:masterfrom Oct 25, 2024
Conversation
These matrices were just filled with `1`, but never used afterwards. This commit prevents "unused variable" warnings, which would occur when the matrices would be filled during their initialization, instead of by calling the `Fill` member function.
github-actions
bot
added
type:Testing
Contributor
Author
|
@dzenanz This still reminds me of your comment at #4894 (comment):
I'm not entirely sure if these "one-filled" matrices answer your question... 😺 |
dzenanz
approved these changes
Oct 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These matrices were just filled with
1, but never used afterwards.This commit prevents "unused variable" warnings, which would occur when the matrices would be filled during their initialization, instead of by calling the
Fillmember function.auto var = itk::MakeFilled<T>in tests #4891) saying warning: unused variable 'direction' [-Wunused-variable]