Remove Fill on empty variables, replace other Fill calls with itk::MakeFilled, in MeshIOTestHelper#4905
Merged
jhlegarreta merged 2 commits intoInsightSoftwareConsortium:masterfrom Oct 27, 2024
Conversation
An instance of `itk::Array`, `itk::VariableLengthVector`, or `itk::VariableSizeMatrix` is empty, when it is just default-constructed. An attempt to `Fill` such an empty object has no effect. - Follow-up to pull request InsightSoftwareConsortium#4898 "Do not `Fill` default-constructed empty local variables in tests"
Replaced code of the form
T var;
var.Fill(x);
with `auto var = itk::MakeFilled<T>(x);`
- Follow-up to pull request InsightSoftwareConsortium#4891
"STYLE: Replace Fill calls with `auto var = itk::MakeFilled<T>` in tests"
github-actions
bot
added
type:Testing
dzenanz
approved these changes
Oct 26, 2024
jhlegarreta
reviewed
Oct 26, 2024
Member
jhlegarreta
left a comment
jhlegarreta
left a comment
There was a problem hiding this comment.
So this is marked as a draft; I'd rather review this once it is ready for review.
Contributor
Author
|
@jhlegarreta I see your point 👍 Hereby I declare this pull request ready for review! |
jhlegarreta
approved these changes
Oct 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed style changes to itkMeshIOTestHelper.h:
Fillcalls on empty local variables (as in pull request Do notFilldefault-constructed empty local variables in tests #4898)Fillcalls withauto var = itk::MakeFilled<T>(as in pull request STYLE: Replace Fill calls withauto var = itk::MakeFilled<T>in tests #4891)