COMP: Fix compile error due to missing itk:: prefix for MakeFilled#5053
Conversation
63b3044 to
de23b75
Compare
N-Dekker
left a comment
There was a problem hiding this comment.
Approved 👍 (Although of course, I wouldn't mind if those unnecessary image->SetOrigin and image->SetSpacing calls would just be removed.)
|
@dzenanz Sorry for missing this one. I turned Review off at one point. |
hjmjohnson
left a comment
There was a problem hiding this comment.
Same sentiments as @N-Dekker .
I think there are a many (~30) places that the removal of explicitly setting origin/spacing could be done. and that should probably be it's own PR.
Search for "SpacingType>(1.0);" to see the list:
git grep "SpacingType>(1.0);"|wc -l (additional-pre-commit-hooks|⚑4✔)
30Sample error message: T:\Dashboard\ITK\Modules\Nonunit\Review\test\itkImageFunctionTest.cxx(137,17): error C2065: 'MakeFilled': undeclared identifier [T:\Dashboard\ITK-build\Modules\Nonunit\Review\test\ITKReviewTestDriver.vcxproj]
de23b75 to
b8d7e06
Compare
This is a test, and as such it exercises those methods. But removed, as that is not the point of this test 😄 |
|
@hjmjohnson this PR fixes a compile error. You are quite welcome to follow up with that style PR. |
Sample error message:
T:\Dashboard\ITK\Modules\Nonunit\Review\test\itkImageFunctionTest.cxx(137,17): error C2065: 'MakeFilled': undeclared identifier [T:\Dashboard\ITK-build\Modules\Nonunit\Review\test\ITKReviewTestDriver.vcxproj]PR Checklist