Skip to content

COMP: Fix compile error due to missing itk:: prefix for MakeFilled#5053

Merged
dzenanz merged 1 commit intoInsightSoftwareConsortium:masterfrom
dzenanz:makeFilledCOMP
Dec 12, 2024
Merged

COMP: Fix compile error due to missing itk:: prefix for MakeFilled#5053
dzenanz merged 1 commit intoInsightSoftwareConsortium:masterfrom
dzenanz:makeFilledCOMP

Conversation

@dzenanz
Copy link
Copy Markdown
Member

@dzenanz dzenanz commented Dec 12, 2024

Sample error message:

T:\Dashboard\ITK\Modules\Nonunit\Review\test\itkImageFunctionTest.cxx(137,17): error C2065: 'MakeFilled': undeclared identifier [T:\Dashboard\ITK-build\Modules\Nonunit\Review\test\ITKReviewTestDriver.vcxproj]

PR Checklist

@github-actions github-actions bot added type:Compiler Compiler support or related warnings type:Testing Ensure that the purpose of a class is met/the results on a wide set of test cases are correct labels Dec 12, 2024
Comment thread Modules/Nonunit/Review/test/itkImageFunctionTest.cxx
Comment thread Modules/Nonunit/Review/test/itkImageFunctionTest.cxx Outdated
Copy link
Copy Markdown
Contributor

@N-Dekker N-Dekker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved 👍 (Although of course, I wouldn't mind if those unnecessary image->SetOrigin and image->SetSpacing calls would just be removed.)

@hjmjohnson
Copy link
Copy Markdown
Member

@dzenanz Sorry for missing this one. I turned Review off at one point.

Copy link
Copy Markdown
Member

@hjmjohnson hjmjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same sentiments as @N-Dekker .

I think there are a many (~30) places that the removal of explicitly setting origin/spacing could be done. and that should probably be it's own PR.

Search for "SpacingType>(1.0);" to see the list:

git grep "SpacingType>(1.0);"|wc -l                                                                   (additional-pre-commit-hooks|⚑4✔)
      30

Sample error message:

T:\Dashboard\ITK\Modules\Nonunit\Review\test\itkImageFunctionTest.cxx(137,17): error C2065: 'MakeFilled': undeclared identifier [T:\Dashboard\ITK-build\Modules\Nonunit\Review\test\ITKReviewTestDriver.vcxproj]
@dzenanz
Copy link
Copy Markdown
Member Author

dzenanz commented Dec 12, 2024

unnecessary image->SetOrigin and image->SetSpacing calls

This is a test, and as such it exercises those methods. But removed, as that is not the point of this test 😄

@dzenanz
Copy link
Copy Markdown
Member Author

dzenanz commented Dec 12, 2024

@hjmjohnson this PR fixes a compile error. You are quite welcome to follow up with that style PR.

@dzenanz dzenanz merged commit 6bee129 into InsightSoftwareConsortium:master Dec 12, 2024
@dzenanz dzenanz deleted the makeFilledCOMP branch December 12, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:Compiler Compiler support or related warnings type:Testing Ensure that the purpose of a class is met/the results on a wide set of test cases are correct

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants